Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: weight tooltip issue #19397

Merged

Conversation

codemaster08240328
Copy link
Contributor

SUMMARY

Screen grid visualization shows Weight undefined

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

  1. Go to chart list
  2. Select send grid chart.
  3. See if weight is undefined or not in tooltip.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 28, 2022

Codecov Report

Merging #19397 (ea8a60f) into master (a4c261d) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #19397      +/-   ##
==========================================
- Coverage   66.59%   66.53%   -0.06%     
==========================================
  Files        1670     1672       +2     
  Lines       63888    63952      +64     
  Branches     6510     6519       +9     
==========================================
+ Hits        42544    42552       +8     
- Misses      19655    19709      +54     
- Partials     1689     1691       +2     
Flag Coverage Δ
javascript 51.25% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-deckgl/src/layers/Screengrid/Screengrid.jsx 0.00% <ø> (ø)
.../components/Header/HeaderActionsDropdown/index.jsx 67.79% <0.00%> (-3.64%) ⬇️
...frontend/src/dashboard/components/Header/index.jsx 60.92% <0.00%> (-0.46%) ⬇️
superset-frontend/src/preamble.ts 0.00% <0.00%> (ø)
superset-frontend/src/embedded/index.tsx 0.00% <0.00%> (ø)
...rc/dashboard/components/DashboardEmbedControls.tsx 8.16% <0.00%> (ø)
...ontend/src/dashboard/containers/DashboardRoute.tsx 0.00% <0.00%> (ø)
...rontend/src/dashboard/containers/DashboardPage.tsx 5.31% <0.00%> (+0.05%) ⬆️
...rset-frontend/src/hooks/apiResources/dashboards.ts 36.36% <0.00%> (+3.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c261d...ea8a60f. Read the comment docs.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rusackas rusackas merged commit f6d550b into apache:master Apr 6, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 6, 2022
* fix: weight tooltip issue

* remove console

(cherry picked from commit f6d550b)
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.13

philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
* fix: weight tooltip issue

* remove console
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.13 Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants