Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(alert & report): make to fix the issue when recreate report #19419

Merged
merged 1 commit into from
Apr 13, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented Mar 29, 2022

SUMMARY

[Explore] Page crashes when user deletes report and then tries to create it again

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
https://media.app.shortcut.com/api/attachments/files/clubhouse-assets/5d8baaab-e1a8-4512-a9c7-12979c8cd1c9/624343bb-1f3f-43be-a418-a2a76d0be05c/Screen%20Recording%202022-03-29%20at%2019.33.42.mov

AFTER:
https://user-images.githubusercontent.com/47900232/160701144-d3bbb2cd-bc01-4289-80b1-1e9ce5492f4b.mov

TESTING INSTRUCTIONS

How to reproduce issues

  1. Enable feature flag ALERT_REPORTS
  2. Open a chart
  3. Create a report (with a calendar icon next to chart header)
  4. Delete that report
  5. Create report again
  6. Crash

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Mar 29, 2022

Codecov Report

Merging #19419 (56f1efb) into master (a619cb4) will increase coverage by 0.00%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #19419   +/-   ##
=======================================
  Coverage   66.48%   66.49%           
=======================================
  Files        1670     1670           
  Lines       63968    63971    +3     
  Branches     6512     6510    -2     
=======================================
+ Hits        42531    42535    +4     
+ Misses      19748    19747    -1     
  Partials     1689     1689           
Flag Coverage Δ
javascript 51.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...rset-frontend/src/components/ReportModal/index.tsx 82.08% <ø> (ø)
...ontend/src/dashboard/components/dnd/DragHandle.tsx 83.33% <0.00%> (-2.39%) ⬇️
...atasourcePanel/DatasourcePanelDragOption/index.tsx 88.88% <0.00%> (-1.12%) ⬇️
...d/src/explore/components/DatasourcePanel/index.tsx 69.23% <0.00%> (-0.13%) ⬇️
...plore/components/controls/OptionControls/index.tsx 75.82% <0.00%> (ø)
...controls/src/components/InfoTooltipWithTrigger.tsx 100.00% <0.00%> (ø)
...-chart-controls/src/components/ColumnTypeLabel.tsx
...src/components/ColumnTypeLabel/ColumnTypeLabel.tsx 100.00% <0.00%> (ø)
...-ui-chart-controls/src/components/MetricOption.tsx 94.73% <0.00%> (+0.29%) ⬆️
...-ui-chart-controls/src/components/ColumnOption.tsx 85.71% <0.00%> (+1.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a619cb4...56f1efb. Read the comment docs.

@prosdev0107
Copy link
Contributor Author

@rusackas
Would you like to merge this PR into master?

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. CC @eschutho just as a courtesy, since this is in your area of concern :D

@rusackas rusackas merged commit 68ed39b into apache:master Apr 13, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants