Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(explore): Chart header icon paddings #19534

Merged
merged 1 commit into from
Apr 6, 2022

Conversation

kgabryje
Copy link
Member

@kgabryje kgabryje commented Apr 5, 2022

SUMMARY

Fix uneven paddings of icons in chart header

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
image

After:
image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@kasiazjc

@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #19534 (15d3022) into master (03d3eaa) will increase coverage by 0.00%.
The diff coverage is 66.66%.

@@           Coverage Diff           @@
##           master   #19534   +/-   ##
=======================================
  Coverage   66.57%   66.57%           
=======================================
  Files        1682     1682           
  Lines       64291    64294    +3     
  Branches     6554     6554           
=======================================
+ Hits        42800    42803    +3     
  Misses      19790    19790           
  Partials     1701     1701           
Flag Coverage Δ
javascript 51.36% <66.66%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-frontend/src/components/AlteredSliceTag/index.jsx 87.87% <ø> (ø)
...rc/explore/components/ExploreChartHeader/index.jsx 42.10% <50.00%> (+1.03%) ⬆️
...uperset-frontend/src/components/FaveStar/index.tsx 100.00% <100.00%> (ø)
superset-frontend/src/profile/App.tsx 0.00% <0.00%> (ø)
...perset-frontend/src/explore/components/Control.tsx 60.00% <0.00%> (+6.15%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 03d3eaa...15d3022. Read the comment docs.

@kgabryje kgabryje merged commit bb96029 into apache:master Apr 6, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants