Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Dates alignment in Table viz #19668

Merged
merged 5 commits into from
Apr 28, 2022
Merged

fix: Dates alignment in Table viz #19668

merged 5 commits into from
Apr 28, 2022

Conversation

geido
Copy link
Member

@geido geido commented Apr 12, 2022

SUMMARY

Fixes #11823

This PR upgrades the Inter font library and applies the tnum property.

AFTER

Screen Shot 2022-04-12 at 20 34 48

TESTING INSTRUCTIONS

  1. Open a Table viz
  2. Group by a date column
  3. Make sure dates are all vertically aligned

ADDITIONAL INFORMATION

  • Has associated issue: dates not aligned in tables #11823
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 15, 2022 •
edited

Codecov Report

Merging #19668 (3d78395) into master (4a835a4) will not change coverage.
The diff coverage is n/a.

❗ Current head 3d78395 differs from pull request most recent head 7a2b379. Consider uploading reports for the commit 7a2b379 to get more accurate results

@@           Coverage Diff           @@
##           master   #19668   +/-   ##
=======================================
  Coverage   66.51%   66.51%           
=======================================
  Files        1714     1714           
  Lines       65026    65026           
  Branches     6710     6710           
=======================================
  Hits        43249    43249           
  Misses      20070    20070           
  Partials     1707     1707
Flag Coverage Δ
javascript 51.22% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/plugins/plugin-chart-table/src/Styles.tsx 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a835a4...7a2b379. Read the comment docs.

kgabryje
kgabryje approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested, works great!

@stephenLYZ
Copy link
Member

It looks like there are a lot of changes to package-lock.json, but we just have only updated one dependency, which seems wired.

@geido geido merged commit ed1309e into apache:master Apr 28, 2022
hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
@geido
fix: Dates alignment in Table viz (apache#19668)
bc466b5 
* Fix dates alignment

* Add package lock changes

* Update package-lock

* Clean up
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@geido @philipher29
fix: Dates alignment in Table viz (apache#19668)
44e004b 
* Fix dates alignment

* Add package lock changes

* Update package-lock

* Clean up
@geido geido mentioned this pull request Jan 18, 2023
Closed
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kgabryje kgabryje kgabryje approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dates not aligned in tables
4 participants
@geido @stephenLYZ @kgabryje @mistercrunch