Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Regression on Data and Alerts & Reports Headers #19850

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

Fixes a regression that happened when trying to fix a "li inside li" error. Switching the tag removed some of the styles applied to the submenu.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

Screen.Recording.2022-04-26.at.08.48.31.mov

After:

Screen.Recording.2022-04-26.at.08.23.31.mov

TESTING INSTRUCTIONS

Visit the Data subsection (Databases/Datasets/Saved queries/Saved history) and ensure the tabs display as showcased in the after video.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #19850 (19ef69e) into master (523bd8b) will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master   #19850      +/-   ##
==========================================
- Coverage   66.55%   66.47%   -0.08%     
==========================================
  Files        1692     1713      +21     
  Lines       64802    64943     +141     
  Branches     6657     6690      +33     
==========================================
+ Hits        43129    43172      +43     
- Misses      19973    20067      +94     
- Partials     1700     1704       +4     
Flag Coverage Δ
javascript 51.16% <100.00%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/components/SubMenu.tsx 86.20% <100.00%> (+0.24%) ⬆️
...-frontend/src/components/AlteredSliceTag/index.jsx 87.87% <0.00%> (ø)
...-frontend/src/visualizations/presets/MainPreset.js 100.00% <0.00%> (ø)
...ontend/plugins/plugin-chart-handlebars/src/i18n.ts 100.00% <0.00%> (ø)
...plugins/plugin-chart-handlebars/src/Handlebars.tsx 0.00% <0.00%> (ø)
...n-chart-handlebars/src/plugin/controls/groupBy.tsx 16.66% <0.00%> (ø)
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 100.00% <0.00%> (ø)
...hart-handlebars/src/plugin/controls/includeTime.ts 100.00% <0.00%> (ø)
...ars/src/components/ControlHeader/controlHeader.tsx 50.00% <0.00%> (ø)
...andlebars/src/components/CodeEditor/CodeEditor.tsx 14.28% <0.00%> (ø)
... and 14 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523bd8b...19ef69e. Read the comment docs.

@rusackas rusackas merged commit 7645eac into apache:master Apr 26, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Apr 27, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.17

hughhhh pushed a commit to hve-labs/superset that referenced this pull request May 11, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.17 Preset-Patch size/S 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants