revert: "fix(sql lab): display the 'View Results' button consistently in the history tab on sync mode" #19906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in the history tab on sync mode (apache#19362)" This reverts commit 6d5d03e.
Codecov Report
@@ Coverage Diff @@
## master #19906 +/- ##
=======================================
Coverage 66.52% 66.53%
=======================================
Files 1714 1714
Lines 65052 65051 -1
Branches 6722 6722
=======================================
+ Hits 43279 43280 +1
+ Misses 20061 20060 -1
+ Partials 1712 1711 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
Gwitchr
changed the title
|
For added context, this PR is reverting the prior fix because it led to a new issue, where results from valid queries were not being displayed properly. To repro:
|
rusackas
approved these changes
May 2, 2022
rusackas
changed the title
|
🏷️ preset:2022.17 |
sadpandajoe
pushed a commit
to preset-io/superset
that referenced
this pull request
May 2, 2022
…in the history tab on sync mode (apache#19362)" (apache#19906) This reverts commit 6d5d03e. (cherry picked from commit 1fa841e)
hughhhh
pushed a commit
to hve-labs/superset
that referenced
this pull request
May 11, 2022
…in the history tab on sync mode (apache#19362)" (apache#19906) This reverts commit 6d5d03e.
philipher29
pushed a commit
to ValtechMobility/superset
that referenced
this pull request
Jun 9, 2022
…in the history tab on sync mode (apache#19362)" (apache#19906) This reverts commit 6d5d03e.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #19362