Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: hack db connection modal ctabtns #20017

Merged
merged 11 commits into from
Jul 5, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented May 10, 2022

SUMMARY

This pr creates two cta buttons to create dataset or to go to sqllab in the db connection modal after a user connects their db

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

Screen.Recording.2022-05-11.at.1.21.32.PM.mov

TESTING INSTRUCTIONS

Go to database connection modal and connect a db. There should be two cta button that take you to create dataset or to sql lab.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@pull-request-size pull-request-size bot added size/L and removed size/M labels May 11, 2022
@codecov
Copy link

codecov bot commented May 11, 2022

Codecov Report

Merging #20017 (6f98cc2) into master (9cf9f97) will increase coverage by 0.08%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master   #20017      +/-   ##
==========================================
+ Coverage   66.35%   66.44%   +0.08%     
==========================================
  Files        1712     1740      +28     
  Lines       64056    64848     +792     
  Branches     6741     6938     +197     
==========================================
+ Hits        42504    43086     +582     
- Misses      19841    20004     +163     
- Partials     1711     1758      +47     
Flag Coverage Δ
javascript 51.81% <50.00%> (+0.51%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/components/DatabaseSelector/index.tsx 88.88% <ø> (ø)
superset-frontend/src/utils/localStorageHelpers.ts 90.00% <ø> (ø)
...s/CRUD/data/database/DatabaseModal/ModalHeader.tsx 66.66% <ø> (ø)
...c/views/CRUD/data/database/DatabaseModal/styles.ts 76.47% <ø> (-0.23%) ⬇️
...c/views/CRUD/data/database/DatabaseModal/index.tsx 31.77% <25.00%> (-0.93%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 56.20% <60.00%> (+0.89%) ⬆️
...d/src/SqlLab/components/SqlEditorLeftBar/index.tsx 49.20% <62.50%> (+1.93%) ⬆️
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx 42.50% <66.66%> (+0.83%) ⬆️
...et-frontend/src/components/TableSelector/index.tsx 76.08% <100.00%> (+0.53%) ⬆️
...oard/components/gridComponents/new/NewMarkdown.jsx 0.00% <0.00%> (-100.00%) ⬇️
... and 289 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9cf9f97...6f98cc2. Read the comment docs.

@yousoph
Copy link
Member

yousoph commented May 20, 2022

/testenv up

@github-actions
Copy link
Contributor

@yousoph Ephemeral environment spinning up at http://34.218.80.71:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@yousoph
Copy link
Member

yousoph commented May 20, 2022

@jess-dillard can you see if the styling on the second step of the db connection screen looks good to you?

@ghost
Copy link

ghost commented May 20, 2022

@pkdotson @yousoph Let's make some styling changes. Make a quick Figma mock here (top part of modal only). Note there are some text tweaks as well.

Screen Shot 2022-05-20 at 1 30 22 PM

@pkdotson
Copy link
Member Author

pkdotson commented Jul 1, 2022

@pkdotson @yousoph Let's make some styling changes. Make a quick Figma mock here (top part of modal only). Note there are some text tweaks as well.

Screen Shot 2022-05-20 at 1 30 22 PM

done

@pkdotson pkdotson merged commit 9da7c1f into apache:master Jul 5, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jul 5, 2022

Ephemeral environment shutdown and build artifacts deleted.

akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* add flow for dbconnmodal to datasetmodal

* fix bug

* second part

* fix dataset to sql lab

* fix lint

* more lint

* add key value

* fix type

* add new styling

* remove undefined from types
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants