Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(homepage): make to show indicator when tab is chosen #20048

Merged
merged 1 commit into from
May 12, 2022

Conversation

prosdev0107
Copy link
Contributor

@prosdev0107 prosdev0107 commented May 12, 2022

SUMMARY

[home page] no indicator for which tab is chosen on recent/dashboard/charts/save query section

Tabs in recents/dashboards/charts/save queries should be indicator when those are chosen.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

BEFORE:
image

AFTER:
image

TESTING INSTRUCTIONS

Repro steps
1, go to home page
2, click on the tabs in recents/dashboards/charts/save queries

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 12, 2022

Codecov Report

Merging #20048 (fee4709) into master (ee178f4) will not change coverage.
The diff coverage is n/a.

❗ Current head fee4709 differs from pull request most recent head 95720b7. Consider uploading reports for the commit 95720b7 to get more accurate results

@@           Coverage Diff           @@
##           master   #20048   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files        1712     1712           
  Lines       64083    64083           
  Branches     6744     6744           
=======================================
  Hits        42523    42523           
  Misses      19847    19847           
  Partials     1713     1713           
Flag Coverage Δ
javascript 51.31% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/views/components/SubMenu.tsx 86.20% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ee178f4...95720b7. Read the comment docs.

@rusackas
Copy link
Member

rusackas commented May 12, 2022

The approach here seems perfectly fine, but I just want to check in with @jess-dillard to see if the Design team has anything different they'd like to see in the visual treatment, which might exist (or need to exist) in our burgeoning design system.

@ghost
Copy link

ghost commented May 12, 2022

We don't have a cohesive component for tabs yet, so this looks fine to me!

@rusackas rusackas merged commit ded9122 into apache:master May 12, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.19

sadpandajoe pushed a commit to preset-io/superset that referenced this pull request May 16, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.19 Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants