Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(api): Added "kind" to dataset/<pk> endpoint #20113

Merged
merged 4 commits into from
Jun 10, 2022

Conversation

reesercollins
Copy link
Contributor

SUMMARY

The “kind” field is already returned by the main dataset GET endpoint. Having the “kind” field returned by the dataset/ endpoint is needed for external services.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

Perform a GET request on the /api/v1/dataset/ endpoint.

ADDITIONAL INFORMATION

  • Has associated issue: Add "kind" to dataset/<pk> endpoint #20110
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 3, 2022

Codecov Report

Merging #20113 (62dcef6) into master (27cccd1) will decrease coverage by 0.03%.
The diff coverage is 80.55%.

❗ Current head 62dcef6 differs from pull request most recent head 30809f8. Consider uploading reports for the commit 30809f8 to get more accurate results

@@            Coverage Diff             @@
##           master   #20113      +/-   ##
==========================================
- Coverage   66.46%   66.43%   -0.04%     
==========================================
  Files        1721     1724       +3     
  Lines       64467    64687     +220     
  Branches     6795     6795              
==========================================
+ Hits        42847    42972     +125     
- Misses      19892    19987      +95     
  Partials     1728     1728              
Flag Coverage Δ
hive ?
mysql 82.28% <90.55%> (+0.15%) ⬆️
postgres 82.35% <91.70%> (+0.16%) ⬆️
presto ?
python 82.43% <91.70%> (-0.19%) ⬇️
sqlite 82.09% <90.78%> (+0.15%) ⬆️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
.../shared-controls/components/RadioButtonControl.tsx 0.00% <ø> (ø)
...d/packages/superset-ui-chart-controls/src/types.ts 100.00% <ø> (ø)
...ackages/superset-ui-core/src/utils/featureFlags.ts 100.00% <ø> (ø)
...egacy-plugin-chart-event-flow/src/controlPanel.tsx 14.28% <0.00%> (ø)
...plugins/legacy-plugin-chart-heatmap/src/Heatmap.js 0.00% <0.00%> (ø)
...acy-plugin-chart-paired-t-test/src/PairedTTest.jsx 0.00% <ø> (ø)
...ugins/legacy-plugin-chart-sunburst/src/Sunburst.js 0.00% <0.00%> (ø)
...gins/legacy-plugin-chart-world-map/src/WorldMap.js 0.00% <0.00%> (ø)
.../legacy-plugin-chart-world-map/src/controlPanel.ts 100.00% <ø> (ø)
...egacy-plugin-chart-world-map/src/transformProps.js 0.00% <0.00%> (ø)
... and 273 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 27cccd1...30809f8. Read the comment docs.

@rusackas rusackas requested a review from zhaoyongjie June 6, 2022 14:39
Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@zhaoyongjie
Copy link
Member

Hi @reesercollins, the CI was stuck in the code format. Could you fix it? Thanks.

@nytai nytai merged commit 11b33de into apache:master Jun 10, 2022
@reesercollins reesercollins deleted the feature/CLDN-1184-upstream branch June 13, 2022 11:52
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants