Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(legacy-plugin-chart-sunburst): chart broken when secondary metric is removed #20223

Merged
merged 1 commit into from
May 31, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixes the problem that sunburst broken when secondary metric is removed

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-05-31.12.03.50.mov

after

2022-05-31.12.13.12.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented May 31, 2022

Codecov Report

Merging #20223 (76d1a90) into master (c8fe518) will not change coverage.
The diff coverage is 0.00%.

❗ Current head 76d1a90 differs from pull request most recent head b5e0d29. Consider uploading reports for the commit b5e0d29 to get more accurate results

@@           Coverage Diff           @@
##           master   #20223   +/-   ##
=======================================
  Coverage   66.47%   66.47%           
=======================================
  Files        1727     1727           
  Lines       64724    64724           
  Branches     6822     6822           
=======================================
  Hits        43024    43024           
  Misses      19969    19969           
  Partials     1731     1731           
Flag Coverage Δ
javascript 51.34% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ontrols/DndColumnSelectControl/DndMetricSelect.tsx 60.74% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c8fe518...b5e0d29. Read the comment docs.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks for the fix.

@stephenLYZ stephenLYZ merged commit ad72ea5 into apache:master May 31, 2022
philipher29 pushed a commit to ValtechMobility/superset that referenced this pull request Jun 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants