Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: query execution time is not fully displayed in bubble icon #20364

Conversation

diegomedina248
Copy link
Contributor

SUMMARY

The query execution time is fully displayed in the green bubble is cut off.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

old

old2

After:

Screen Shot 2022-06-13 at 15 28 09

Screen Shot 2022-06-13 at 15 30 07

TESTING INSTRUCTIONS

  1. Open SQL lab
  2. Run any query
  3. Pay attention to the query execution time (in bubble icon)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 13, 2022

Codecov Report

Merging #20364 (e2e489c) into master (cb2ffa5) will not change coverage.
The diff coverage is n/a.

❗ Current head e2e489c differs from pull request most recent head 4ffedf5. Consider uploading reports for the commit 4ffedf5 to get more accurate results

@@           Coverage Diff           @@
##           master   #20364   +/-   ##
=======================================
  Coverage   66.63%   66.63%           
=======================================
  Files        1738     1738           
  Lines       65078    65078           
  Branches     6885     6885           
=======================================
  Hits        43367    43367           
  Misses      19963    19963           
  Partials     1748     1748           
Flag Coverage Δ
javascript 51.68% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset-frontend/src/components/Timer/index.tsx 78.94% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cb2ffa5...4ffedf5. Read the comment docs.

@rusackas rusackas merged commit e1532f6 into apache:master Jun 13, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.0.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels Preset-Patch size/XS 🚢 2.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants