fix: Allow dataset owners to explore their datasets #20382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cccs-tom
approved these changes
Jun 15, 2022
|
@dpgaspar I see you approved the original fix to the linked issue. Would you mind taking a look? |
Codecov Report
@@ Coverage Diff @@
## master #20382 +/- ##
=======================================
Coverage 66.75% 66.75%
=======================================
Files 1740 1740
Lines 65156 65160 +4
Branches 6900 6900
=======================================
+ Hits 43492 43496 +4
Misses 19915 19915
Partials 1749 1749
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
@reesercollins thanks for the fix -- what's the ETA for getting this merged? We have some users blocked on this issue. Thanks! |
reesercollins
force-pushed
the
fix/CLDN-1482
branch
from
e512171
to
4e8ff45
Compare
michael-s-molina
pushed a commit
that referenced
this pull request
Jul 6, 2022
* fix: Allow dataset owners to explore their datasets * Re-order imports * Give owners security manager permissions to their datasets * Update test suite * Add SqlaTable to is_owner types * Add owners to datasource mock * Fix VSCode import error * Fix merge error
john-bodley
added a commit
that referenced
this pull request
Jul 6, 2022
This reverts commit f910958.
codyml
pushed a commit
to codyml/superset
that referenced
this pull request
Jul 7, 2022
* fix: Allow dataset owners to explore their datasets * Re-order imports * Give owners security manager permissions to their datasets * Update test suite * Add SqlaTable to is_owner types * Add owners to datasource mock * Fix VSCode import error * Fix merge error
akshatsri
pushed a commit
to charan1314/superset
that referenced
this pull request
Jul 19, 2022
* fix: Allow dataset owners to explore their datasets * Re-order imports * Give owners security manager permissions to their datasets * Update test suite * Add SqlaTable to is_owner types * Add owners to datasource mock * Fix VSCode import error * Fix merge error
mistercrunch
added
🍒 2.0.0
🍒 2.0.1
🚢 2.1.3
🚢 2.1.0
and removed
🍒 2.0.1
🍒 2.0.0
🚢 2.1.3
labels
mistercrunch
added
🍒 2.0.0
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This fixes a missed codepath by @cccs-tom's fix to #19360 which was pointed out by @HeathLee.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
Try to explore a dataset which you own. You should now be able to.
ADDITIONAL INFORMATION