Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds support for clearing the Select cache #20397

Merged
merged 2 commits into from
Jun 21, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Adds support for clearing the Select cache.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen.Recording.2022-06-15.at.1.48.16.PM.mov

TESTING INSTRUCTIONS

Check the video for instructions.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 15, 2022

Codecov Report

Merging #20397 (c959d92) into master (86f146e) will increase coverage by 0.18%.
The diff coverage is 86.20%.

❗ Current head c959d92 differs from pull request most recent head 74db6b3. Consider uploading reports for the commit 74db6b3 to get more accurate results

@@            Coverage Diff             @@
##           master   #20397      +/-   ##
==========================================
+ Coverage   66.52%   66.70%   +0.18%     
==========================================
  Files        1739     1739              
  Lines       65141    65135       -6     
  Branches     6900     6897       -3     
==========================================
+ Hits        43336    43451     +115     
+ Misses      20052    19931     -121     
  Partials     1753     1753              
Flag Coverage Δ
hive 53.70% <0.00%> (?)
javascript 51.74% <85.71%> (+0.02%) ⬆️
mysql 82.29% <100.00%> (ø)
postgres 82.36% <100.00%> (+<0.01%) ⬆️
presto 53.56% <0.00%> (?)
python 82.78% <100.00%> (+0.34%) ⬆️
sqlite 82.09% <100.00%> (ø)
unit 50.15% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...art-controls/src/operators/contributionOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/flattenOperator.ts 100.00% <ø> (ø)
...ui-chart-controls/src/operators/prophetOperator.ts 100.00% <ø> (ø)
...i-chart-controls/src/operators/resampleOperator.ts 100.00% <ø> (ø)
...chart-echarts/src/MixedTimeseries/controlPanel.tsx 65.00% <ø> (ø)
...gins/plugin-chart-echarts/src/Pie/controlPanel.tsx 28.57% <0.00%> (-4.77%) ⬇️
...chart-echarts/src/Timeseries/Area/controlPanel.tsx 33.33% <ø> (ø)
...charts/src/Timeseries/Regular/Bar/controlPanel.tsx 33.33% <ø> (ø)
...ts/src/Timeseries/Regular/Scatter/controlPanel.tsx 33.33% <ø> (ø)
...rt-echarts/src/Timeseries/Regular/controlPanel.tsx 33.33% <ø> (ø)
... and 31 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 86f146e...74db6b3. Read the comment docs.

@@ -40,7 +41,7 @@ export type PluginFilterGroupByProps = PluginFilterStylesProps & {
data: DataRecord[];
filterState: FilterState;
formData: PluginFilterGroupByQueryFormData;
inputRef: RefObject<HTMLInputElement>;
inputRef: RefObject<SelectRef>;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is the inputRef used anywhere to access attributes from the HTMLInputElement directly?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. It's used here to automatically focus the filters:

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@michael-s-molina michael-s-molina merged commit ca526e6 into apache:master Jun 21, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* feat: Adds support for clearing the Select cache

* Fixes lint errors
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants