fix: alert & reports active toggle optimistic update #20402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20402 +/- ##
=======================================
Coverage 66.52% 66.53%
=======================================
Files 1739 1739
Lines 65141 65142 +1
Branches 6900 6900
=======================================
+ Hits 43336 43343 +7
+ Misses 20052 20046 -6
Partials 1753 1753
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
|
||
| updateResource(update_id, { active: checked }, false, false) | ||
| .then() | ||
| .catch(() => setResourceCollection(original)); |
There was a problem hiding this comment.
Shouldn't we display a toast for the user like "An error occurred while changing the active state"?
There was a problem hiding this comment.
We are. The updateResource comes from the useSingleViewResource hook, which accepts a function to handle errors and we're passing addDangerToast to it.
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 23, 2022
(cherry picked from commit 4dc3044)
michael-s-molina
pushed a commit
that referenced
this pull request
Jun 28, 2022
(cherry picked from commit 4dc3044)
mistercrunch
added
🍒 2.0.0
🍒 2.0.1
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
For the alert and reports, the active toggle could lag and give the user the impression nothing is happening.
This PR just uses an optimistic update instead, and revert the change if the API fails.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-06-15.at.16.50.44.mov
After:
new.mov
TESTING INSTRUCTIONS
The expected result is that the user sees the toggle pretty quickly.
ADDITIONAL INFORMATION