Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(vizgallery): Double-click viz type to submit form #20513

Conversation

codyml
Copy link
Member

@codyml codyml commented Jun 27, 2022

SUMMARY

This PR streamlines the process of creating a chart or changing a chart's visualization type by allowing the user to double-click a visualization type in the viz type gallery to automatically submit the form. On the AddSlice page, this only works if the user has already selected a dataset.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  1. Visit /chart/add.
  2. Without selecting a dataset, double-click on a viz type. Ensure that nothing happens other than that viz type being selected in the gallery.
  3. Select a dataset, then double-click on a different viz type. Ensure that the form automatically submits, redirecting to Explore with the dataset and new viz type selected.
  4. On Explore, click "View all charts" in the "Vizualization type" control to open the "Select a visualization type" modal.
  5. Double-click on a new viz type and ensure that the modal disappears and the new viz type is active.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 27, 2022

Codecov Report

Merging #20513 (dcc7fec) into master (f29cde2) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20513   +/-   ##
=======================================
  Coverage   66.85%   66.85%           
=======================================
  Files        1749     1749           
  Lines       65411    65414    +3     
  Branches     6906     6907    +1     
=======================================
+ Hits        43730    43735    +5     
+ Misses      19931    19930    -1     
+ Partials     1750     1749    -1     
Flag Coverage Δ
javascript 51.85% <100.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plore/components/controls/VizTypeControl/index.tsx 73.07% <ø> (ø)
...perset-frontend/src/addSlice/AddSliceContainer.tsx 68.18% <100.00%> (+2.32%) ⬆️
...ponents/controls/VizTypeControl/VizTypeGallery.tsx 88.17% <100.00%> (+1.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f29cde2...dcc7fec. Read the comment docs.

@stephenLYZ
Copy link
Member

/testenv up

@github-actions
Copy link
Contributor

@stephenLYZ Ephemeral environment spinning up at http://54.188.161.167:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@michael-s-molina michael-s-molina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michael-s-molina michael-s-molina merged commit 280b4be into apache:master Jun 28, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
* Make double-clicking on viz type submit the form.

* Add tests.
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants