Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: apply standardized form data to tier 2 charts #20530

Merged
merged 1 commit into from
Jun 29, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

Apply StandardizedFormData to the following charts

  • Mapbox
  • Partition chart
  • Nightingale rose chart
  • Sankey diagram
  • Sunburst chart
  • Timeseries table
  • Word cloud

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jun 29, 2022

Codecov Report

Merging #20530 (927d066) into master (927d066) will not change coverage.
The diff coverage is n/a.

❗ Current head 927d066 differs from pull request most recent head d711a12. Consider uploading reports for the commit d711a12 to get more accurate results

@@           Coverage Diff           @@
##           master   #20530   +/-   ##
=======================================
  Coverage   66.84%   66.84%           
=======================================
  Files        1751     1751           
  Lines       65440    65440           
  Branches     6912     6912           
=======================================
  Hits        43746    43746           
  Misses      19945    19945           
  Partials     1749     1749           
Flag Coverage Δ
hive 53.78% <0.00%> (ø)
javascript 51.84% <0.00%> (ø)
mysql 82.40% <0.00%> (ø)
postgres 82.47% <0.00%> (ø)
presto 53.64% <0.00%> (ø)
python 82.90% <0.00%> (ø)
sqlite 82.26% <0.00%> (ø)
unit 50.67% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 927d066...d711a12. Read the comment docs.

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit de524bc into apache:master Jun 29, 2022
akshatsri pushed a commit to charan1314/superset that referenced this pull request Jul 19, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants