fix: superset-ui/core code coverage #20676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
commented
Jul 12, 2022
| @@ -43,7 +43,6 @@ export default function processFilters( | |||
| const { adhoc_filters, extras = {}, filters = [], where } = formData; | |||
| const simpleWhere: QueryObjectFilterClause[] = filters; | |||
|
|
|||
| const simpleHaving: QueryObjectFilterClause[] = []; | |||
There was a problem hiding this comment.
discussion from PR, should remove druid simpleHaving clause
zhaoyongjie
commented
Jul 12, 2022
Comment on lines
-57
to
-58
| } else { | ||
| simpleHaving.push(filterClause); |
There was a problem hiding this comment.
use only in native druid connector.
zhaoyongjie
requested review from
suddjian,
AAfghahi,
ktmud,
rusackas,
stephenLYZ and
kgabryje
Codecov Report
@@ Coverage Diff @@
## master #20676 +/- ##
=======================================
Coverage 66.85% 66.85%
=======================================
Files 1753 1753
Lines 65827 65825 -2
Branches 7006 7006
=======================================
Hits 44010 44010
+ Misses 20031 20030 -1
+ Partials 1786 1785 -1
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
to fix master
superset-ui/corecoverage breaks CI.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
N/A
TESTING INSTRUCTIONS
pass all CI
ADDITIONAL INFORMATION