Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Revert "feat: Reuse Dashboard redux data in Explore (#20668)" #20689

Merged
merged 1 commit into from
Jul 12, 2022

Conversation

kgabryje
Copy link
Member

SUMMARY

This PR reverts #20668.
When user applies native filters and then clicked "Edit chart", the native filters are not added to adhoc filters in Explore.
This problem will disappear when we refactor the way that we transition from Dashboard to Explore (coming in a few days)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 12, 2022

Codecov Report

Merging #20689 (59ac1ff) into master (ff5b4bc) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

❗ Current head 59ac1ff differs from pull request most recent head e2bb0b6. Consider uploading reports for the commit e2bb0b6 to get more accurate results

@@            Coverage Diff             @@
##           master   #20689      +/-   ##
==========================================
- Coverage   66.85%   66.85%   -0.01%     
==========================================
  Files        1753     1753              
  Lines       65839    65833       -6     
  Branches     7007     7007              
==========================================
- Hits        44017    44011       -6     
  Misses      20036    20036              
  Partials     1786     1786              
Flag Coverage Δ
javascript 51.95% <33.33%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/packages/superset-ui-core/src/utils/isDefined.ts 100.00% <ø> (ø)
superset-frontend/src/dashboard/actions/hydrate.js 2.06% <ø> (ø)
.../src/dashboard/components/gridComponents/Chart.jsx 56.60% <0.00%> (ø)
superset-frontend/src/explore/ExplorePage.tsx 0.00% <0.00%> (ø)
superset/charts/schemas.py 99.34% <ø> (-0.02%) ⬇️
...set-frontend/src/explore/actions/hydrateExplore.ts 60.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ff5b4bc...e2bb0b6. Read the comment docs.

@michael-s-molina michael-s-molina merged commit 5317462 into apache:master Jul 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants