Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: blankstate metrics columns #20755

Merged
merged 106 commits into from
Jul 26, 2022

Conversation

pkdotson
Copy link
Member

@pkdotson pkdotson commented Jul 18, 2022

SUMMARY

This pr updates the blank state to the metrics and columns controls and add a cta for user to save dataset if they using query to power chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

after

Screen.Recording.2022-06-27.at.11.41.58.PM.mov

TESTING INSTRUCTIONS

Must use a query to power chart in order to test this pr. Create a query from sqllab and then create chart. Check metrics and columns controls and check for updated blank state.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

hughhhh and others added 30 commits June 6, 2022 15:09
> columns are loading into page
…ype is Query [41493]

Initial commit to add ability for the a Query Preview Modal to be available when the data source type is Query and not Dataset
Converted ModalTrigger to a functional TypeScript component
> allow for all records to be displayed
> fix select with all columns queries
> filters are now working
…view-modal-for-chart-source-query

feat: Ericbriscoe/sc 41493/query preview modal for chart source query
…set, adds default metric when chart source is query
… datasource

A follow on separate effort will enable having a default Count metric when Query is the datasource type
@pkdotson pkdotson changed the title Feat blankstate metrics columns feat: blankstate metrics columns Jul 18, 2022
Copy link
Member

@AAfghahi AAfghahi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just two nits.

@hughhhh hughhhh force-pushed the feat-blankstate-metrics-columns branch from c7877ed to dc74d2b Compare July 25, 2022 16:28
@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #20755 (69009be) into master (e3c6380) will decrease coverage by 0.04%.
The diff coverage is 13.04%.

@@            Coverage Diff             @@
##           master   #20755      +/-   ##
==========================================
- Coverage   66.30%   66.25%   -0.05%     
==========================================
  Files        1757     1757              
  Lines       66860    66976     +116     
  Branches     7077     7117      +40     
==========================================
+ Hits        44332    44377      +45     
- Misses      20719    20782      +63     
- Partials     1809     1817       +8     
Flag Coverage Δ
javascript 51.91% <13.04%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ols/DndColumnSelectControl/ColumnSelectPopover.tsx 3.26% <0.00%> (-0.49%) ⬇️
...ols/MetricControl/AdhocMetricEditPopover/index.jsx 75.53% <0.00%> (-2.50%) ⬇️
...ntrols/MetricControl/AdhocMetricPopoverTrigger.tsx 78.04% <25.00%> (-5.74%) ⬇️
...ColumnSelectControl/ColumnSelectPopoverTrigger.tsx 63.63% <50.00%> (-1.89%) ⬇️
...components/DashboardBuilder/DashboardContainer.tsx 40.00% <0.00%> (-32.23%) ⬇️
...set-frontend/src/explore/actions/hydrateExplore.ts 42.10% <0.00%> (-17.90%) ⬇️
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 50.00% <0.00%> (-16.67%) ⬇️
...tend/plugins/plugin-chart-handlebars/src/consts.ts 66.66% <0.00%> (-8.34%) ⬇️
...nd/plugins/plugin-chart-table/src/controlPanel.tsx 45.58% <0.00%> (-0.79%) ⬇️
...src/dashboard/components/PropertiesModal/index.tsx 62.19% <0.00%> (-0.63%) ⬇️
... and 12 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

@hughhhh hughhhh merged commit 2f3e11d into apache:master Jul 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants