Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Redirects old Explore URLs to the new ones #20812

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

michael-s-molina
Copy link
Member

@michael-s-molina michael-s-molina commented Jul 21, 2022

SUMMARY

To preserve bookmarked URLs this PR redirects old Explore URLs in the format /superset/explore to the new one without the /superset prefix. This only affects GET operations. We only preserved the POST operation in case anyone is using it for something. In any case, this endpoint will be deleted in 3.0 as the warning clearly states.

Follow-up of #20572

TESTING INSTRUCTIONS

Check if old Explore URLs are redirected to the new ones with all parameters preserved.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@michael-s-molina michael-s-molina changed the title fix: Redirects old Explore URLs to the new one fix: Redirects old Explore URLs to the new ones Jul 21, 2022
@codecov
Copy link

codecov bot commented Jul 21, 2022

Codecov Report

Merging #20812 (db7175e) into master (922b4b8) will decrease coverage by 0.17%.
The diff coverage is 50.00%.

❗ Current head db7175e differs from pull request most recent head 714286c. Consider uploading reports for the commit 714286c to get more accurate results

@@            Coverage Diff             @@
##           master   #20812      +/-   ##
==========================================
- Coverage   66.29%   66.12%   -0.18%     
==========================================
  Files        1758     1758              
  Lines       66801    66803       +2     
  Branches     7055     7055              
==========================================
- Hits        44288    44173     -115     
- Misses      20713    20830     +117     
  Partials     1800     1800              
Flag Coverage Δ
hive ?
mysql 80.98% <50.00%> (-0.01%) ⬇️
postgres 81.04% <50.00%> (-0.02%) ⬇️
presto ?
python 81.14% <50.00%> (-0.36%) ⬇️
sqlite 79.54% <50.00%> (-0.01%) ⬇️
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/core.py 75.64% <50.00%> (-0.04%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 70.22% <0.00%> (-15.65%) ⬇️
superset/db_engine_specs/presto.py 83.64% <0.00%> (-5.39%) ⬇️
superset/reports/commands/log_prune.py 85.71% <0.00%> (-3.58%) ⬇️
superset/initialization/__init__.py 89.93% <0.00%> (-1.74%) ⬇️
superset/commands/importers/v1/utils.py 92.20% <0.00%> (-1.30%) ⬇️
superset/connectors/sqla/models.py 89.20% <0.00%> (-1.15%) ⬇️
superset/common/query_object.py 93.87% <0.00%> (-0.52%) ⬇️
superset/reports/commands/execute.py 91.24% <0.00%> (-0.37%) ⬇️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us.

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@rusackas rusackas merged commit 34278c2 into apache:master Jul 22, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 22, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.29

@AAfghahi AAfghahi added the logging Creates a UI or API endpoint that could benefit from logging. label Aug 5, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels logging Creates a UI or API endpoint that could benefit from logging. size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants