Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: invalid dataset schema #20826

Merged
merged 1 commit into from
Jul 23, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jul 22, 2022

SUMMARY

The owner field in the SqlaTable model should be a Dict instead of an int type. the regression is from PR

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

open.explore.from.dashboard.mov

TESTING INSTRUCTIONS

should open explore page on dashboard

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Jul 22, 2022

Codecov Report

Merging #20826 (108a40b) into master (3954535) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##           master   #20826      +/-   ##
==========================================
- Coverage   66.30%   66.30%   -0.01%     
==========================================
  Files        1757     1757              
  Lines       66806    66808       +2     
  Branches     7059     7059              
==========================================
+ Hits        44297    44298       +1     
- Misses      20711    20712       +1     
  Partials     1798     1798              
Flag Coverage Δ
hive 53.23% <50.00%> (-0.01%) ⬇️
mysql 80.98% <75.00%> (-0.01%) ⬇️
postgres 81.05% <75.00%> (-0.01%) ⬇️
presto 53.09% <50.00%> (-0.01%) ⬇️
python 81.49% <75.00%> (-0.01%) ⬇️
sqlite 79.54% <75.00%> (-0.01%) ⬇️
unit 50.24% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/dashboards/api.py 92.48% <66.66%> (-0.25%) ⬇️
superset/dashboards/schemas.py 99.46% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@rusackas rusackas requested a review from eschutho July 22, 2022 16:31
Copy link
Member

@hughhhh hughhhh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zhaoyongjie zhaoyongjie merged commit 3fb5c79 into apache:master Jul 23, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Jul 25, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.29

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants