Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch form_data between different datasource #20867

Merged
merged 1 commit into from
Jul 26, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Jul 26, 2022

SUMMARY

The Standardized Form Data is an ephemeral state keeper for keeping form_data between different viz. it doesn't consider switching between different data sources. If the SFD keeps a state for a viz and datasource changed, the query in the changed data source did not take effect. This PR reset the Standardized Form Data when datasource chaged

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

switch.ds.before.mov

After

switch.ds.after.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@@ -61,6 +59,114 @@ const adhocMetricSimple: AdhocMetricSimple = {
optionName: 'count',
};

const tableVizFormData = {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Constants just move to the top of file, no change.

@codecov
Copy link

codecov bot commented Jul 26, 2022

Codecov Report

Merging #20867 (d84e038) into master (55a89df) will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #20867   +/-   ##
=======================================
  Coverage   66.27%   66.27%           
=======================================
  Files        1757     1757           
  Lines       66954    66961    +7     
  Branches     7107     7108    +1     
=======================================
+ Hits        44372    44379    +7     
  Misses      20767    20767           
  Partials     1815     1815           
Flag Coverage Δ
javascript 51.93% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...d/src/explore/controlUtils/standardizedFormData.ts 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us.

@zhaoyongjie zhaoyongjie merged commit cb9ae38 into apache:master Jul 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants