fix: Address performance regression introduced in #11785 #20893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
john-bodley
commented
Jul 27, 2022
| if not self.schema: | ||
| return self.table_name | ||
| return "{}.{}".format(self.schema, self.table_name) | ||
| return self.schema + "." + self.table_name if self.schema else self.table_name |
There was a problem hiding this comment.
The logic needed to be translated into a function that SQLAlchemy could understand as we're using this hybrid property as a filter.
john-bodley
force-pushed
the
john-bodley--optimize-sqllab-table-metadata
branch
from
422a29d
to
37a19c4
Compare
Codecov Report
@@ Coverage Diff @@
## master #20893 +/- ##
===========================================
- Coverage 66.27% 54.80% -11.48%
===========================================
Files 1758 1758
Lines 67072 67072
Branches 7122 7122
===========================================
- Hits 44453 36759 -7694
- Misses 20800 28494 +7694
Partials 1819 1819
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
ktmud
approved these changes
Jul 28, 2022
john-bodley
force-pushed
the
john-bodley--optimize-sqllab-table-metadata
branch
2 times, most recently
from
25dbfcd
to
64e5572
Compare
john-bodley
force-pushed
the
john-bodley--optimize-sqllab-table-metadata
branch
from
64e5572
to
a9d2e54
Compare
9 tasks
john-bodley
added a commit
that referenced
this pull request
Oct 13, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR fixes a SQL Lab performance regression introduced in https://github.com/apache/superset/pull/11785—a mere two years ago—which impacts the populating the tables in the SQL Lab LHS.
Specially at Airbnb for the Presto database the following line
would take over 5 seconds to execute given we have over 100,000 tables registered with said database in Superset. The fix is to bypass the SQLAlchemy ORM and fetch only the subset of relevant tables using the SQLAlchemy Query API. The resulting refactor reduced the statement execution time down to << 0.01 seconds.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
CI.
ADDITIONAL INFORMATION