fix(sqllab): hide tracking url when fetching #20905
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #20905 +/- ##
==========================================
- Coverage 66.31% 66.31% -0.01%
==========================================
Files 1758 1758
Lines 67008 67010 +2
Branches 7107 7109 +2
==========================================
Hits 44437 44437
Misses 20749 20749
- Partials 1822 1824 +2
Flags with carried forward coverage won't be shown. Click here to find out more.
Help us with your feedback. Take ten seconds to tell us how you rate us. |
john-bodley
approved these changes
Jul 29, 2022
rusackas
reviewed
Aug 8, 2022
| @@ -80,6 +78,14 @@ interface ResultSetState { | |||
| alertIsOpen: boolean; | |||
| } | |||
|
|
|||
| const Styles = styled.div` | |||
| position: relative; | |||
| minheight: 100px; | |||
There was a problem hiding this comment.
I think this needs to be min-height @ktmud
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
Hide tracking url when SQL Lab is fetching query results or when query is successful. Also fix missing margin when progress bar hasn't show up.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
After
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION