feat(helm): add RollingUpdate parameters #20931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gforien
requested review from
craig-rueda,
dpgaspar and
villebro
as code owners
craig-rueda
reviewed
Aug 1, 2022
helm/superset/Chart.yaml
Outdated
| @@ -22,7 +22,7 @@ maintainers: | |||
| - name: craig-rueda | |||
| email: craig@craigrueda.com | |||
| url: https://github.com/craig-rueda | |||
| version: 0.6.6 | |||
| version: 0.6.7 | |||
craig-rueda
reviewed
Aug 1, 2022
| @@ -33,6 +33,11 @@ spec: | |||
| matchLabels: | |||
| app: {{ template "superset.name" . }}-worker | |||
| release: {{ .Release.Name }} | |||
| strategy: | |||
| type: RollingUpdate | |||
There was a problem hiding this comment.
Pls make the strategy configurable. You can just add the whole strategy section into values.yaml and then call toYaml here.
|
Hi @gforien would be great if you could rebase and address the requested changes. Thank you! |
|
Hi @dpgaspar |
gforien
force-pushed
the
feat/helm/add-rollingupdate-parameters
branch
from
661b8d1
to
f54187c
Compare
|
Hi 👋 |
craig-rueda
reviewed
Sep 21, 2022
helm/superset/Chart.yaml
Outdated
| @@ -22,7 +22,7 @@ maintainers: | |||
| - name: craig-rueda | |||
| email: craig@craigrueda.com | |||
| url: https://github.com/craig-rueda | |||
| version: 0.7.2 | |||
| version: 0.7.3 | |||
There was a problem hiding this comment.
Prob need to bump this one more time
There was a problem hiding this comment.
Did not know which one you would merge first :)
gforien
force-pushed
the
feat/helm/add-rollingupdate-parameters
branch
from
f54187c
to
809696a
Compare
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
We want to handle the RollingUpdate parameters for the supersetNode and supersetWorker.
How
deployment.yamlanddeployment-worker.yamltemplatesvalues.yamlTESTING INSTRUCTIONS
helm lint helm template . superset-releaseADDITIONAL INFORMATION