Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: series limit solution for source is query #20977

Merged
merged 5 commits into from
Aug 4, 2022
Merged

fix: series limit solution for source is query #20977

merged 5 commits into from
Aug 4, 2022

Conversation

AAfghahi
Copy link
Member

@AAfghahi AAfghahi commented Aug 4, 2022 •
edited

SUMMARY

This allows a datasource being a query to create a time series line chart.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Screen Shot 2022-08-04 at 1 52 09 PM

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@AAfghahi AAfghahi force-pushed the arash/series_limit_solution branch from 7a28491 to d802fdc Compare August 4, 2022 17:49
@pull-request-size pull-request-size bot added size/M and removed size/L labels Aug 4, 2022
@AAfghahi AAfghahi force-pushed the arash/series_limit_solution branch from d802fdc to ce1f247 Compare August 4, 2022 17:51
@AAfghahi
Copy link
Member Author

AAfghahi commented Aug 4, 2022

/testenv up

@codecov
Copy link

codecov bot commented Aug 4, 2022 •
edited

Codecov Report

Merging #20977 (5c5f3a3) into master (fa416fa) will decrease coverage by 11.47%.
The diff coverage is 0.00%.

❗ Current head 5c5f3a3 differs from pull request most recent head c89a916. Consider uploading reports for the commit c89a916 to get more accurate results

@@             Coverage Diff             @@
##           master   #20977       +/-   ##
===========================================
- Coverage   66.33%   54.85%   -11.48%     
===========================================
  Files        1767     1767               
  Lines       67273    67280        +7     
  Branches     7138     7138               
===========================================
- Hits        44626    36908     -7718     
- Misses      20821    28546     +7725     
  Partials     1826     1826
Flag Coverage Δ
hive 53.14% <0.00%> (-0.02%) ⬇️
postgres ?
presto 53.04% <0.00%> (-0.02%) ⬇️
python 57.77% <0.00%> (-23.69%) ⬇️
sqlite ?
unit 50.47% <0.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/models/helpers.py 36.09% <0.00%> (-3.62%) ⬇️
superset/utils/dashboard_import_export.py 0.00% <0.00%> (-100.00%) ⬇️
superset/key_value/commands/update.py 0.00% <0.00%> (-88.89%) ⬇️
superset/key_value/commands/delete.py 0.00% <0.00%> (-85.30%) ⬇️
superset/key_value/commands/delete_expired.py 0.00% <0.00%> (-80.77%) ⬇️
superset/dashboards/commands/importers/v0.py 15.62% <0.00%> (-76.25%) ⬇️
superset/datasets/commands/update.py 25.00% <0.00%> (-69.05%) ⬇️
superset/datasets/commands/create.py 29.41% <0.00%> (-68.63%) ⬇️
superset/datasets/commands/importers/v0.py 24.03% <0.00%> (-67.45%) ⬇️
superset/views/datasource/utils.py 27.90% <0.00%> (-67.45%) ⬇️
... and 278 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@AAfghahi AAfghahi force-pushed the arash/series_limit_solution branch from ce1f247 to c89a916 Compare August 4, 2022 18:29
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

@AAfghahi Container image not yet published for this PR. Please try again when build is complete.

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

@AAfghahi Ephemeral environment creation failed. Please check the Actions logs for details.

@yousoph
Copy link
Member

yousoph commented Aug 4, 2022

/testenv up

@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

@yousoph Ephemeral environment spinning up at http://18.236.149.140:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@hughhhh hughhhh merged commit e350823 into master Aug 4, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Aug 4, 2022

Ephemeral environment shutdown and build artifacts deleted.

jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Aug 4, 2022
@AAfghahi @jinghua-qa
fix: series limit solution for source is query (apache#20977)
550215f 
* fix

* save

* integrate type casting for engiines

* fix orderby on column types

* fixes

Co-authored-by: Hugh A. Miles II <hughmil3s@gmail.com>
(cherry picked from commit e350823)
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
@mistercrunch mistercrunch deleted the arash/series_limit_solution branch March 26, 2024 16:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hughhhh hughhhh hughhhh approved these changes

Assignees
No one assigned
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.31 size/M 🚢 2.1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@AAfghahi @yousoph @hughhhh @mistercrunch @jinghua-qa