Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: for series limit comparison on explore with chart = Query #20989

Merged
merged 2 commits into from
Aug 5, 2022

Conversation

hughhhh
Copy link
Member

@hughhhh hughhhh commented Aug 5, 2022

SUMMARY

Duck typing on query context to handle whenever the users is requesting to run a Query vs. SqlaTable in explore. This specifically fixes the issue with time comparisons in time series queries

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #20989 (c669fa5) into master (eec6e57) will decrease coverage by 0.21%.
The diff coverage is 75.00%.

❗ Current head c669fa5 differs from pull request most recent head 1f4f059. Consider uploading reports for the commit 1f4f059 to get more accurate results

@@            Coverage Diff             @@
##           master   #20989      +/-   ##
==========================================
- Coverage   66.34%   66.13%   -0.22%     
==========================================
  Files        1767     1767              
  Lines       67284    67286       +2     
  Branches     7140     7140              
==========================================
- Hits        44642    44501     -141     
- Misses      20815    20958     +143     
  Partials     1827     1827              
Flag Coverage Δ
hive ?
mysql 80.92% <75.00%> (-0.01%) ⬇️
postgres 80.99% <75.00%> (-0.01%) ⬇️
presto ?
python 81.04% <75.00%> (-0.44%) ⬇️
sqlite ?
unit ?

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/common/query_context_processor.py 89.28% <75.00%> (-0.36%) ⬇️
superset/db_engines/hive.py 0.00% <0.00%> (-85.19%) ⬇️
superset/db_engine_specs/hive.py 71.04% <0.00%> (-15.84%) ⬇️
superset/db_engine_specs/presto.py 81.36% <0.00%> (-6.62%) ⬇️
superset/db_engine_specs/sqlite.py 91.89% <0.00%> (-5.41%) ⬇️
superset/utils/celery.py 86.20% <0.00%> (-3.45%) ⬇️
superset/connectors/sqla/utils.py 86.36% <0.00%> (-2.28%) ⬇️
superset/models/sql_lab.py 75.00% <0.00%> (-2.02%) ⬇️
superset/initialization/__init__.py 89.96% <0.00%> (-1.74%) ⬇️
superset/result_set.py 96.24% <0.00%> (-1.51%) ⬇️
... and 5 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@pull-request-size pull-request-size bot added size/S and removed size/XS labels Aug 5, 2022
@hughhhh hughhhh merged commit be4fbaf into apache:master Aug 5, 2022
jinghua-qa pushed a commit to preset-io/superset that referenced this pull request Aug 5, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset:2022.31 size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants