fix: Validate required fields in sql_json API #21003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #21003 +/- ##
==========================================
- Coverage 66.34% 66.18% -0.16%
==========================================
Files 1767 1768 +1
Lines 67312 67367 +55
Branches 7144 7144
==========================================
- Hits 44656 44586 -70
- Misses 20828 20953 +125
Partials 1828 1828
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@hughhhh @betodealmeida Can you review it? |
|
Hi @EugeneTorap, Thanks for adding validation on the endpoint. Do you mind following the Mashmallow validation schema for the requesting validation? Here are some examples. |
Thanks, will do it |
zhaoyongjie
reviewed
Aug 11, 2022
zhaoyongjie
approved these changes
Aug 11, 2022
zhaoyongjie
reviewed
Aug 11, 2022
Comment on lines
+790
to
+791
| self.assertDictEqual(resp_data, failed_resp) | ||
| self.assertEqual(rv.status_code, 400) |
Comment on lines
+800
to
+801
| self.assertDictEqual(resp_data, failed_resp) | ||
| self.assertEqual(rv.status_code, 400) |
Comment on lines
+809
to
+810
| self.assertEqual(resp_data.get("status"), "success") | ||
| self.assertEqual(rv.status_code, 200) |
Comment on lines
+779
to
+781
| resp_data = json.loads(rv.data.decode("utf-8")) | ||
| self.assertDictEqual(resp_data, failed_resp) | ||
| self.assertEqual(rv.status_code, 400) |
There was a problem hiding this comment.
no blocking, nits
Suggested change
| resp_data = json.loads(rv.data.decode("utf-8")) | |
| self.assertDictEqual(resp_data, failed_resp) | |
| self.assertEqual(rv.status_code, 400) | |
| assert rv.json == failed_resp | |
| assert rv.status_code == 400 |
rusackas
reviewed
Aug 22, 2022
| # "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY | ||
| # KIND, either express or implied. See the License for the | ||
| # specific language governing permissions and limitations | ||
| # under the License. |
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #20873 issues.
SUMMARY
sql_json API has two required fields:
We need to validate these fields if they are
Noneand send user an understandable error if one of the fields is missing.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION