Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(plugin-chart-handlebars): Sort-By and Sort-By-Descending control not work #21005

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

stephenLYZ
Copy link
Member

SUMMARY

This PR fixes the problem that sort-by control not working in the handlebar chart.

  • use normalizeOrderBy to normalize the value of sort-by control
  • only make sort-descending control visible when sort-by control has values
  • change the order of the sort-descending control

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before

2022-08-07.10.35.18.mov

after

2022-08-07.10.33.15.mov

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #21005 (4ceac51) into master (e214e1a) will decrease coverage by 0.00%.
The diff coverage is 33.33%.

@@            Coverage Diff             @@
##           master   #21005      +/-   ##
==========================================
- Coverage   66.34%   66.34%   -0.01%     
==========================================
  Files        1767     1767              
  Lines       67312    67313       +1     
  Branches     7144     7144              
==========================================
  Hits        44656    44656              
- Misses      20828    20830       +2     
+ Partials     1828     1827       -1     
Flag Coverage Δ
javascript 52.11% <33.33%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...lugin-chart-handlebars/src/plugin/controlPanel.tsx 50.00% <ø> (ø)
...n-chart-handlebars/src/plugin/controls/orderBy.tsx 28.57% <0.00%> (-11.43%) ⬇️
...s/plugin-chart-handlebars/src/plugin/buildQuery.ts 100.00% <100.00%> (+25.00%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@rusackas
Copy link
Member

/testenv up

@rusackas
Copy link
Member

I have a handlebars chart I'll test this with asap...

@github-actions
Copy link
Contributor

@rusackas Ephemeral environment spinning up at http://35.162.149.229:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

@zhaoyongjie zhaoyongjie self-requested a review August 22, 2022 07:00
@zhaoyongjie zhaoyongjie merged commit e70699f into apache:master Aug 22, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

eschutho pushed a commit that referenced this pull request Sep 20, 2022
Fahrenheit35 pushed a commit to Fahrenheit35/superset that referenced this pull request Nov 11, 2022
@mistercrunch mistercrunch added 🍒 2.0.1 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S v2.0 v2.0.1 🍒 2.0.1 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants