-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: supports mulitple filters in samples endpoint #21008
feat: supports mulitple filters in samples endpoint #21008
Conversation
reset |
Codecov Report
@@ Coverage Diff @@
## master #21008 +/- ##
=======================================
Coverage 66.34% 66.35%
=======================================
Files 1767 1767
Lines 67312 67332 +20
Branches 7144 7144
=======================================
+ Hits 44656 44675 +19
- Misses 20828 20829 +1
Partials 1828 1828
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes LGTM!
SUMMARY
In order to support drill to detail with filters, adds
DRILL DETAIL
query type and supports arbitrary filters in/datasource/samples
endpointsBEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
pure backend codes change, so screenshots are not suitable
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION