Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: supports mulitple filters in samples endpoint #21008

Merged
merged 4 commits into from
Aug 8, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Aug 8, 2022

SUMMARY

In order to support drill to detail with filters, adds DRILL DETAIL query type and supports arbitrary filters in /datasource/samples endpoints

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

pure backend codes change, so screenshots are not suitable

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review August 8, 2022 07:01
@LeeyCul
Copy link

LeeyCul commented Aug 8, 2022

reset

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #21008 (0539c59) into master (e214e1a) will increase coverage by 0.00%.
The diff coverage is 90.90%.

@@           Coverage Diff           @@
##           master   #21008   +/-   ##
=======================================
  Coverage   66.34%   66.35%           
=======================================
  Files        1767     1767           
  Lines       67312    67332   +20     
  Branches     7144     7144           
=======================================
+ Hits        44656    44675   +19     
- Misses      20828    20829    +1     
  Partials     1828     1828           
Flag Coverage Δ
hive 53.13% <27.27%> (-0.02%) ⬇️
mysql 80.95% <90.90%> (+0.02%) ⬆️
postgres 81.00% <90.90%> (+<0.01%) ⬆️
presto 53.03% <27.27%> (-0.02%) ⬇️
python 81.48% <90.90%> (+<0.01%) ⬆️
sqlite 79.60% <90.90%> (+0.02%) ⬆️
unit 50.45% <27.27%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/views/datasource/utils.py 93.33% <66.66%> (-2.02%) ⬇️
superset/common/query_actions.py 92.39% <92.85%> (+0.08%) ⬆️
superset/common/chart_data.py 100.00% <100.00%> (ø)
superset/views/datasource/schemas.py 100.00% <100.00%> (ø)
superset/db_engine_specs/mysql.py 98.80% <0.00%> (+1.19%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

Copy link
Member

@codyml codyml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code changes LGTM!

@zhaoyongjie zhaoyongjie merged commit 802b69f into apache:master Aug 8, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants