Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): result set min-height #21016

Merged
merged 1 commit into from
Aug 9, 2022
Merged

Conversation

ktmud
Copy link
Member

@ktmud ktmud commented Aug 8, 2022

SUMMARY

Fix a typo in SQL Lab CSS. It was from an inline-style to styled-components migration.

See: #20905 (comment)

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

N/A

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

Copy link
Member

@rusackas rusackas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@codecov
Copy link

codecov bot commented Aug 8, 2022

Codecov Report

Merging #21016 (da672a4) into master (bb3871d) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21016   +/-   ##
=======================================
  Coverage   66.35%   66.35%           
=======================================
  Files        1767     1767           
  Lines       67348    67348           
  Branches     7144     7144           
=======================================
  Hits        44691    44691           
  Misses      20829    20829           
  Partials     1828     1828           
Flag Coverage Δ
javascript 52.11% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...frontend/src/SqlLab/components/ResultSet/index.tsx 51.70% <ø> (ø)

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@ktmud ktmud merged commit 58245dd into apache:master Aug 9, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants