Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add extension point for workspace home page #21033

Merged
merged 13 commits into from
Aug 15, 2022

Conversation

riahk
Copy link
Contributor

@riahk riahk commented Aug 10, 2022

SUMMARY

  • Adds registration points for new welcome page views + related UI changes to support these extensions
  • Update to ListViewCard: optional subtitle section
  • Update to antd radio component to support radio buttons
  • Add fields to charts api GET by id: changed_on_delta_humanized, id, thumbnail_url, url
  • Add field to saved query api GET by id: changed_on_delta_humanized

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

  • Update python integration test (chart api)

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@riahk riahk marked this pull request as ready for review August 10, 2022 19:35
@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #21033 (394d62e) into master (394d62e) will not change coverage.
The diff coverage is n/a.

❗ Current head 394d62e differs from pull request most recent head e1a4d11. Consider uploading reports for the commit e1a4d11 to get more accurate results

@@           Coverage Diff           @@
##           master   #21033   +/-   ##
=======================================
  Coverage   66.27%   66.27%           
=======================================
  Files        1770     1770           
  Lines       67524    67524           
  Branches     7178     7178           
=======================================
  Hits        44754    44754           
  Misses      20936    20936           
  Partials     1834     1834           
Flag Coverage Δ
hive 53.16% <0.00%> (ø)
javascript 52.00% <0.00%> (ø)
mysql 80.95% <0.00%> (ø)
postgres 81.01% <0.00%> (ø)
presto 53.06% <0.00%> (ø)
python 81.49% <0.00%> (ø)
sqlite 79.61% <0.00%> (ø)
unit 50.72% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@lilykuang lilykuang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@riahk riahk force-pushed the moriah/workspace-home-ui-extension branch from 6841919 to e1a4d11 Compare August 13, 2022 00:04
@lilykuang lilykuang merged commit 83dd851 into apache:master Aug 15, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels preset-io size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants