Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(utils): use getaddrinfo response to support dual-stack port checks #21043

Merged
merged 1 commit into from
Sep 2, 2022

Conversation

vin01
Copy link
Contributor

@vin01 vin01 commented Aug 10, 2022

fixes port check to test ipv6 addresses as well, addresses #21041

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #21043 (e9eceb9) into master (ab6ec89) will increase coverage by 0.00%.
The diff coverage is 0.00%.

@@           Coverage Diff           @@
##           master   #21043   +/-   ##
=======================================
  Coverage   66.26%   66.26%           
=======================================
  Files        1769     1769           
  Lines       67475    67478    +3     
  Branches     7171     7171           
=======================================
+ Hits        44711    44716    +5     
+ Misses      20933    20931    -2     
  Partials     1831     1831           
Flag Coverage Δ
hive 53.14% <0.00%> (-0.01%) ⬇️
mysql 80.93% <0.00%> (+<0.01%) ⬆️
postgres 80.98% <0.00%> (+<0.01%) ⬆️
presto 53.04% <0.00%> (-0.01%) ⬇️
python 81.46% <0.00%> (+<0.01%) ⬆️
sqlite 79.59% <0.00%> (+<0.01%) ⬆️
unit 50.48% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
superset/utils/network.py 34.37% <0.00%> (-3.56%) ⬇️
superset/views/sql_lab.py 63.81% <0.00%> (+3.28%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@betodealmeida betodealmeida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@betodealmeida betodealmeida merged commit 38782bb into apache:master Sep 2, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/S 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants