Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Total on Table Chart gets cut off on the Dashboard if the Chart is re-sized #21063

Closed
3 tasks done
rusackas opened this issue Aug 11, 2022 · 1 comment · Fixed by #21064
Closed
3 tasks done

Total on Table Chart gets cut off on the Dashboard if the Chart is re-sized #21063

rusackas opened this issue Aug 11, 2022 · 1 comment · Fixed by #21064
Labels
#bug Bug report

Comments

@rusackas
Copy link
Member

rusackas commented Aug 11, 2022

The total count from an aggregated Table Chart gets cut off on the Dashboard, after re-sizing it.

How to reproduce the bug

  1. Access Superset.
  2. Create a Table Chart using the Vehicle Sales Dataset.
  3. Set product_line on the Dimensions.
  4. Set SUM(price_each) on the Metrics.
  5. Enable SHOW TOTALS.
  6. Click on Create Chart.
  7. Access the CUSTOMIZE tab.
  8. Change the SUM(price_each) D3 format to Original value.
  9. Save the Chart and add it to a new Dashboard.
  10. Edit the Dashboard, and decrease the Chart height so that a vertical scroll bar appears.
  11. Increase the height so that all rows are visible.
  12. Save your changes

Expected results

The Total number should display as expected.

Actual results

The Total number is cut off
(will paste screenshot/video here - Github is being problematic here at the moment)

Known Workarounds

Manually re-sizing the Chart so that the number is properly displayed might fix the issue. Reports are mixed.

Environment

(please complete the following information):

  • browser type and version: Chrome (on PC)
  • superset version: latest master

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@rusackas rusackas added the #bug Bug report label Aug 11, 2022
@reesercollins
Copy link
Contributor

reesercollins commented Aug 11, 2022

This seems to be solved by removing the table-layout: fixed from the "Total" wrapper element. Not sure what other problems doing this may cause, but I can't seem to see any at the moment.

EDIT: Upon further inspection, the underlying issue is with superset's code, and can be fixed fairly easily. PR coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants