Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SUPERSET_VERSION_RC might not be set and lead to failing tarball creation. #21082

Open
3 tasks done
Joel-Haeberli opened this issue Aug 14, 2022 · 1 comment · May be fixed by #21083
Open
3 tasks done

SUPERSET_VERSION_RC might not be set and lead to failing tarball creation. #21082

Joel-Haeberli opened this issue Aug 14, 2022 · 1 comment · May be fixed by #21083
Labels
#bug Bug report

Comments

@Joel-Haeberli
Copy link

How to reproduce the bug

  1. Execute [SOURCE_DIR]/RELEASING/make_tarball.sh in an environment you never used before and the release ENV-Variables are not set.
./make_tarball.sh [VERSION] [RC] [PGP_KEY_NAME]
  1. The script fails with
gpg: can't open '/[YOUR_RELEASE_DIR]/svn/superset_dev/2.0.0rc2/apache-superset--source.tar.gz': No such file or directory
gpg: signing failed: No such file or directory

Expected results

I expect the script to build the correct versioned tarball.

Actual results

Tarball without the correct name leading to errors in the script which expects the name with the correct version.

Screenshots

see Point 2 in 'How to reproduce the bug'

Environment

  • Theoretically all environments.
  • Versions of browsers etc. not relevant.

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.
@Joel-Haeberli Joel-Haeberli added the #bug Bug report label Aug 14, 2022
@Joel-Haeberli Joel-Haeberli linked a pull request Aug 14, 2022 that will close this issue
9 tasks
@rusackas
Copy link
Member

rusackas commented Feb 9, 2024

@Joel-Haeberli we were checking in on that PR still, but is this still an issue at all as of Superset 3.x? We'll leave it open for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants