Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Helm: Default busybox init container does not reference .Values.envFromSecrets #21110

Open
3 tasks done
martimors opened this issue Aug 17, 2022 · 0 comments
Open
3 tasks done
Assignees
Labels
#bug Bug report

Comments

@martimors
Copy link
Contributor

A clear and concise description of what the bug is.

How to reproduce the bug

  1. Specify a custom externally managed secret in .Values.envFromSecrets
  2. helm install
  3. Observe that the busybox container init scripts cannot find the env variable you wanted to give it

Expected results

The secrets should be available here as in all other containers by default

Actual results

In my case, the netcat call failed because the DB host could not be found

Checklist

Make sure to follow these steps before submitting your issue - thank you!

  • I have checked the superset logs for python stacktraces and included it here as text if there are any.
  • I have reproduced the issue with at least the latest released version of superset.
  • I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

It could be a bit finnicky to do because the default script only exists in valyes.yml, thus using if/else would cause a circular dependency. It would therefore involve moving the default init container into _helpers.tpl. What do you think, is it worth the effort and complexity? I don't mind implementing it myself but would love some community feedback before I start.

@martimors martimors added the #bug Bug report label Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report
Projects
None yet
Development

No branches or pull requests

2 participants