Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resample method shouldn't be freeform #21135

Merged
merged 1 commit into from
Aug 22, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Aug 19, 2022

SUMMARY

The Fill method in Advanced Analytics shouldn't be freeform. When this control sets to freeform, the fill method will be arbitrary.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

zero.fill.mov

After

zerofill-after.mov

TESTING INSTRUCTIONS

The Fill Method control shouldn't input arbitrary values.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@zhaoyongjie zhaoyongjie marked this pull request as ready for review August 19, 2022 08:23
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #21135 (234f2e2) into master (252ceb7) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21135   +/-   ##
=======================================
  Coverage   66.32%   66.32%           
=======================================
  Files        1772     1772           
  Lines       67651    67651           
  Branches     7205     7205           
=======================================
  Hits        44867    44867           
  Misses      20941    20941           
  Partials     1843     1843           
Flag Coverage Δ
javascript 52.08% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...-chart-controls/src/sections/advancedAnalytics.tsx 14.28% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Member

@stephenLYZ stephenLYZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@zhaoyongjie zhaoyongjie merged commit fea68ef into apache:master Aug 22, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants