Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Typing of labelMap #21181

Merged
merged 2 commits into from
Aug 26, 2022

Conversation

michael-s-molina
Copy link
Member

SUMMARY

Fixes the typing of labelMap to use string instead of DataRecordValue as values.

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #21181 (a115181) into master (53de94c) will decrease coverage by 0.00%.
The diff coverage is 88.23%.

@@            Coverage Diff             @@
##           master   #21181      +/-   ##
==========================================
- Coverage   66.40%   66.39%   -0.01%     
==========================================
  Files        1781     1781              
  Lines       67874    67893      +19     
  Branches     7239     7248       +9     
==========================================
+ Hits        45069    45077       +8     
- Misses      20946    20954       +8     
- Partials     1859     1862       +3     
Flag Coverage Δ
javascript 52.30% <88.23%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...packages/superset-ui-core/src/query/types/Query.ts 100.00% <ø> (ø)
.../plugin-chart-echarts/src/MixedTimeseries/types.ts 100.00% <ø> (ø)
...s/plugin-chart-echarts/src/Radar/transformProps.ts 0.00% <0.00%> (ø)
...ns/plugin-chart-echarts/src/utils/eventHandlers.ts 0.00% <ø> (ø)
...plugin-chart-echarts/src/BoxPlot/transformProps.ts 54.23% <100.00%> (ø)
.../plugin-chart-echarts/src/Funnel/transformProps.ts 71.73% <100.00%> (ø)
...s/plugin-chart-echarts/src/Gauge/transformProps.ts 76.92% <100.00%> (ø)
...ins/plugin-chart-echarts/src/Pie/transformProps.ts 55.07% <100.00%> (ø)
...plugin-chart-echarts/src/Treemap/transformProps.ts 51.51% <100.00%> (ø)
...ase/DatabaseModal/DatabaseConnectionForm/index.tsx 90.90% <0.00%> (-9.10%) ⬇️
... and 7 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie
Copy link
Member

@michael-s-molina the types here and here also needs to be changed.

Copy link
Member

@zhaoyongjie zhaoyongjie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixing! LGTM

Copy link
Member

@geido geido left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@github-actions
Copy link
Contributor

Storybook has completed and can be viewed at

@michael-s-molina michael-s-molina merged commit 1143e17 into apache:master Aug 26, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants