Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): unable to create new tabs #21260

Merged

Conversation

justinpark
Copy link
Member

SUMMARY

The queryEditor's name can be undefined during localStorage hydration.
This commit skips the mappedUntitled case rather than throwing an error for this case.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

image (8)

TESTING INSTRUCTIONS

N/A

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Aug 30, 2022

Codecov Report

Merging #21260 (1b2b0d1) into master (05354a9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #21260   +/-   ##
=======================================
  Coverage   66.43%   66.43%           
=======================================
  Files        1784     1784           
  Lines       68185    68185           
  Branches     7265     7265           
=======================================
  Hits        45298    45298           
  Misses      21018    21018           
  Partials     1869     1869           
Flag Coverage Δ
javascript 52.49% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...erset-frontend/src/SqlLab/utils/newQueryTabName.ts 86.66% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@john-bodley john-bodley merged commit 034ee1c into apache:master Aug 30, 2022
john-bodley pushed a commit to airbnb/superset-fork that referenced this pull request Aug 30, 2022
justinpark added a commit to airbnb/superset-fork that referenced this pull request Sep 16, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants