-
Notifications
You must be signed in to change notification settings - Fork 13.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dataset creating issues in SQL Lab #21271
Comments
@yousoph Should this get prioritized? |
@diegomedina248 Can you take a look at these issues? |
I believe #21244 fixes the second issue mentioned |
For the first issue - looks like it happens if you use the same tab to try to save the dataset. If you refresh the SQL Lab tab, the error message appears properly. I think the modal shouldn't keep the previous name when it's closed and reopened - I think that might fix the problem? Would you be up to opening a PR for a fix @EugeneTorap ? (Thanks for the find, btw!) |
Yes, I check it out the second issue. It's fixed after this merged PR |
@AAfghahi Can you take a look at first issue? |
@EugeneTorap sure i can look into it. |
I found 2 interesting bugs when we want to create a dataset in SQL Lab:
Untitled Query 7 08/31/2022 17:58:02
name but input hasqwe1
nameqwe1
then modal window is disappeared and don't handle error from server.Expected results
We handle server error response and show "Dataset [qwe1] already exists" on UI side to user.
Actual results
Server error response is not handled.
Screenshots
Screen.Recording.2022-08-31.at.17.57.51.mov
Screen.Recording.2022-08-31.at.18.06.39.mov
Environment
(please complete the following information):
superset version
python --version
node -v
Checklist
Make sure to follow these steps before submitting your issue - thank you!
Additional context
Add any other context about the problem here.
@michael-s-molina @kgabryje @villebro @lyndsiWilliams
The text was updated successfully, but these errors were encountered: