Dataset creating issues in SQL Lab

[EugeneTorap]

I found 2 interesting bugs when we want to create a dataset in SQL Lab:

1. When we create a dataset and provide some name and then want to do it again with the same name. In second dataset creation we got Untitled Query 7 08/31/2022 17:58:02 name but input has qwe1 name
2. [FIXED] When we reload page and create a duplicate name of dataset for example name=qwe1 then modal window is disappeared and don't handle error from server.

Expected results

We handle server error response and show "Dataset [qwe1] already exists" on UI side to user.

Actual results

Server error response is not handled.

Screenshots

Screen.Recording.2022-08-31.at.17.57.51.mov

Screen.Recording.2022-08-31.at.18.06.39.mov

Environment

(please complete the following information):

• browser type and version:
• superset version: superset version
• python version: python --version
• node.js version: node -v
• any feature flags active:

Checklist

Make sure to follow these steps before submitting your issue - thank you!

• I have checked the superset logs for python stacktraces and included it here as text if there are any.
• I have reproduced the issue with at least the latest released version of superset.
• I have checked the issue tracker for the same issue and I haven't found one similar.

Additional context

Add any other context about the problem here.
@michael-s-molina @kgabryje @villebro @lyndsiWilliams

[kgabryje]

@yousoph Should this get prioritized?

[EugeneTorap]

@diegomedina248 Can you take a look at these issues?

[yousoph]

I believe #21244 fixes the second issue mentioned

[yousoph]

For the first issue - looks like it happens if you use the same tab to try to save the dataset. If you refresh the SQL Lab tab, the error message appears properly. I think the modal shouldn't keep the previous name when it's closed and reopened - I think that might fix the problem? Would you be up to opening a PR for a fix @EugeneTorap ? (Thanks for the find, btw!)

[EugeneTorap]

I believe #21244 fixes the second issue mentioned

Yes, I check it out the second issue. It's fixed after this merged PR

[EugeneTorap]

@AAfghahi Can you take a look at first issue?

[AAfghahi]

@EugeneTorap sure i can look into it.