fix(explore): Incorrect conversion from simple bool filter to custom sql #21293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -66,10 +66,10 @@ export function optionLabel(opt) { | |||
| return EMPTY_STRING; | |||
| } | |||
| if (opt === true) { | |||
| return '<true>'; | |||
| return 'true'; | |||
There was a problem hiding this comment.
Can we use the TRUE_STRING and FALSE_STRING constants?
There was a problem hiding this comment.
Done! Though now we'll have TRUE instead of true in the labels
| @@ -28,9 +28,9 @@ describe('utils/common', () => { | |||
| it('converts values as expected', () => { | |||
| expect(optionFromValue(false)).toEqual({ | |||
| value: false, | |||
| label: '<false>', | |||
There was a problem hiding this comment.
Can we use the constants here as well?
Codecov Report
@@ Coverage Diff @@
## master #21293 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 1784 1784
Lines 68237 68237
Branches 7263 7263
=======================================
Hits 45328 45328
Misses 21040 21040
Partials 1869 1869
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
michael-s-molina
approved these changes
Sep 1, 2022
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
This PR removes brackets around
trueandfalsewhen automatically converting boolean simple adhoc filter to a custom sql filter.BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before:
Screen.Recording.2022-09-01.at.15.07.52.mov
After:
Screen.Recording.2022-09-01.at.15.06.40.mov
TESTING INSTRUCTIONS
trueorfalseand that query works correctlyADDITIONAL INFORMATION