Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added latin america countries to country map #21352

Merged
merged 2 commits into from
Sep 30, 2022

Conversation

bryanjtc
Copy link
Contributor

@bryanjtc bryanjtc commented Sep 7, 2022

SUMMARY

Added argentina, bolivia, chile, colombia, costa rica, cuba, dominican republic, ecuador, el salvador, guatemala, haiti, honduras, nicaragua, panama, paraguay, puerto rico, saint barthelemy, saint martin and venezuela.
Fixes #21440

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

venezuela
saint martin
saint barthelemy
puerto rico
paraguay
panama
nicaragua
honduras
haiti
guatemala
el salvador
ecuador
dominican republic
cuba
costa rica
chile
colombia
bolivia
argentina

TESTING INSTRUCTIONS

Clone the repo and go to its root directory. Run the following shell commands:

cd superset-frontend && npm install
npm run plugins:storybook

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@bryanjtc bryanjtc changed the title feat: Added latin america countries feat: Added latin america countries to country map Sep 7, 2022
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️
We hope to see you in our Slack community too!

Copy link
Member

@villebro villebro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this wonderful addition! One question; did you use the Country Map GeoJSON Generator.ipynb file to generate the new files? If so, would it be possible to add the changes to the notebook so these can be recreated later if needed?

@codecov
Copy link

codecov bot commented Sep 15, 2022

Codecov Report

Merging #21352 (b0e6abb) into master (875e9f8) will increase coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master   #21352      +/-   ##
==========================================
+ Coverage   66.58%   66.64%   +0.06%     
==========================================
  Files        1790     1791       +1     
  Lines       68420    68436      +16     
  Branches     7287     7268      -19     
==========================================
+ Hits        45557    45611      +54     
+ Misses      20986    20964      -22     
+ Partials     1877     1861      -16     
Flag Coverage Δ
javascript 52.85% <ø> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...s/legacy-plugin-chart-country-map/src/countries.ts 100.00% <ø> (ø)
...s/CRUD/data/dataset/AddDataset/LeftPanel/index.tsx 46.42% <0.00%> (-53.58%) ⬇️
...t-controls/src/sections/echartsTimeSeriesQuery.tsx 33.33% <0.00%> (-16.67%) ⬇️
...iews/CRUD/data/dataset/AddDataset/Header/index.tsx 87.50% <0.00%> (-12.50%) ⬇️
...perset-ui-chart-controls/src/sections/sections.tsx 87.50% <0.00%> (-12.50%) ⬇️
...ontend/src/explore/controlUtils/getControlState.ts 80.32% <0.00%> (-10.42%) ⬇️
.../legacy-plugin-chart-histogram/src/controlPanel.ts 40.00% <0.00%> (-10.00%) ⬇️
...perset-frontend/src/views/components/RightMenu.tsx 60.83% <0.00%> (-2.50%) ⬇️
...ard/components/DrillDetailPane/DrillDetailPane.tsx 81.01% <0.00%> (-1.75%) ⬇️
superset-frontend/src/views/CRUD/utils.tsx 64.28% <0.00%> (-0.52%) ⬇️
... and 42 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@bryanjtc
Copy link
Contributor Author

@villebro Yes. I did use the generator file. I just pushed the file with the changes.

Copy link
Member

@ktmud ktmud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the updates! At some point maybe we should just add all countries, lol.

@bryanjtc
Copy link
Contributor Author

@betodealmeida Did you reviewed my changes. Do I need to change anything?

@villebro
Copy link
Member

@bryanjtc thanks for the reminder. This has been open long enough, so I started CI flow and can merge once it's ready if CI is green

@villebro villebro merged commit f83af88 into apache:master Sep 30, 2022
@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XXL 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[SIP-89] Proposal for adding latin america countries to country map
4 participants