Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(big number): time grain control is useless in BigNumber Viz #21372

Merged
merged 1 commit into from
Sep 8, 2022

Conversation

zhaoyongjie
Copy link
Member

SUMMARY

The Time Grain control is useless in BigNumber Viz(without trendline).

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before

image

After

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 8, 2022

Codecov Report

Merging #21372 (48d95ce) into master (b302818) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #21372   +/-   ##
=======================================
  Coverage   66.61%   66.61%           
=======================================
  Files        1791     1791           
  Lines       68538    68538           
  Branches     7310     7310           
=======================================
  Hits        45655    45655           
  Misses      21002    21002           
  Partials     1881     1881           
Flag Coverage Δ
javascript 52.79% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...harts/src/BigNumber/BigNumberTotal/controlPanel.ts 100.00% <ø> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@zhaoyongjie zhaoyongjie merged commit b80f659 into apache:master Sep 8, 2022
@john-bodley
Copy link
Member

@zhaoyongjie should this change also contain a database migration which removes the time_grain_sqla parameters if the viz_type is big_number?

@zhaoyongjie
Copy link
Member Author

zhaoyongjie commented Nov 8, 2022

@john-bodley the Big Number chart hasn't a columns-like control, so the time_grain never be applied on the chart. IMO, the database migration is unnecessary.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/XS 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants