Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts reinserted into dashboards they were deleted from after save(overwrite) #21434

Closed
C-monC opened this issue Sep 12, 2022 · 3 comments
Closed
Labels
#bug Bug report preset:cares Preset cares about this issue

Comments

@C-monC
Copy link

C-monC commented Sep 12, 2022

Hi,

Reproduction steps:
Dashboard A and dashboard B had chart A in.
Delete chart A from dashboard B.
Modify chart A and save(overwrite)
Chart A then reappears in dashboard B.

I can see there is a link to dashboard B in the columns query_context and params:
....,"conditional_formatting":[],"extra_form_data":{},"dashboards":[11,42],"force":false,"result_format":"json......
Dashboard B has id 11 and Dashboard A has id 42.

The dashboard column does not include the chart A anywhere. Searched for the id in its json columns.

A workaround is just recreating the chart and not inserting into dashboard B.
This is a major security concern because there's no indication it happened. I need to manually review dashboards to look for data leakage.

@C-monC C-monC added the #bug Bug report label Sep 12, 2022
@C-monC
Copy link
Author

C-monC commented Sep 12, 2022

This also blocks saving if the dashboard does not exist - Response "Dashboard does not exist".

@rusackas rusackas added the preset:cares Preset cares about this issue label Sep 15, 2022
@codyml
Copy link
Member

codyml commented Oct 6, 2022

I think this was fixed in #21497. Let me know if you can still reproduce!

@C-monC
Copy link
Author

C-monC commented Apr 27, 2023

This was fixed, thanks.

@C-monC C-monC closed this as completed Apr 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
#bug Bug report preset:cares Preset cares about this issue
Projects
None yet
Development

No branches or pull requests

3 participants