fix: remove extras from all adhoc_filters controls

[villebro]

SUMMARY

When setting native or filter box filters in a dashboard and then exploring a Mixed Timeseries chart and then saving the chart, the extra filters are only removed from the first query. This PR changes the removal logic so that all controls that start with the text adhoc_filters are cleaned from extra filters before saving. The logic is added both to the deprecated backend logic (set for removal in 3.0) and the new frontend logic which cleans the extra adhoc filters before sending the request to the v1 chart API.

AFTER

With this fix the extra filters are removed from the second query of the mixed chart (notice there are no extra filters in the adhoc filter control):

BEFORE

Previously saving the mixed chart with an extra filter would persist the extra filters in the chart metadata:

TESTING INSTRUCTIONS

1. Create a Mixed chart
2. Add it to a dashboard and create a native filter
3. Apply the native filter to the chart and edit the chart
4. Save the chart and notice that the extra filter is removed from Query A but is still present in Query B after saving.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21450 (d9c3eea) into master (9c285da) will increase coverage by 0.00%.
The diff coverage is 80.00%.

❗ Current head d9c3eea differs from pull request most recent head 978519f. Consider uploading reports for the commit 978519f to get more accurate results

@@           Coverage Diff           @@
##           master   #21450   +/-   ##
=======================================
  Coverage   66.53%   66.54%           
=======================================
  Files        1791     1791           
  Lines       68599    68602    +3     
  Branches     7320     7320           
=======================================
+ Hits        45645    45648    +3     
  Misses      21064    21064           
  Partials     1890     1890           

Flag	Coverage Δ
javascript	52.75% <75.00%> (+<0.01%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset/views/core.py	75.05% <ø> (ø)
...t-frontend/src/explore/actions/saveModalActions.js	98.46% <75.00%> (+0.07%)	⬆️
superset/utils/core.py	90.00% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[zhaoyongjie]

Tested in my local then it works well! Thanks for the fixing!