fix: Duplicated numeric values in Select

[michael-s-molina]

SUMMARY

When allowNewOptions was true and the options contained numbers as values, if the user searched for a value that already existed, the options would be duplicated because hasOption was not transforming the string input before comparing it with the existing values. Given that the possible value types are string | number | null | undefined, this PR changes that logic to use the equality operator (not strict) to compare the values.

@cccs-RyanK

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

before.mov

Screen.Recording.2022-09-13.at.3.20.22.PM.mov

TESTING INSTRUCTIONS

Check the videos for instructions.

ADDITIONAL INFORMATION

• Has associated issue:
• Required feature flags:
• Changes UI
• Includes DB Migration (follow approval process in SIP-59)
  • Migration is atomic, supports rollback & is backwards-compatible
  • Confirm DB migration upgrade and downgrade tested
  • Runtime estimates and downtime expectations provided
• Introduces new feature or API
• Removes existing feature or API

[codecov]

Codecov Report

Merging #21480 (b1028d9) into master (4fcc1d9) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master   #21480   +/-   ##
=======================================
  Coverage   66.67%   66.67%           
=======================================
  Files        1791     1791           
  Lines       68459    68459           
  Branches     7268     7268           
=======================================
  Hits        45643    45643           
  Misses      20955    20955           
  Partials     1861     1861           

Flag	Coverage Δ
javascript	52.85% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
superset-frontend/src/components/Select/utils.tsx	81.52% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[geido]

/testenv up

[github-actions]

@geido Ephemeral environment spinning up at http://54.245.190.12:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

[github-actions]

Ephemeral environment shutdown and build artifacts deleted.