feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected #21530

Antonio-RiveroMartnez · 2022-09-20T13:23:07Z

SUMMARY

We are adding some extra logic to RightMenu so it checks for what databases the user has connected before displaying options in the dropdown.

Plus menu logic:

Connect database: shows for users who can create databases, until their first non examples db is connected
Create dataset: shows for users who can create a dataset as soon as at least one non examples db is connected
[no change] Connect Google Sheet: shows for users who can create databases, always
[no change] Upload CSV, columnar, Excel: shows for users who can create databases all the time (tooltip when no csv uploads enabled, active when csv uploads enabled). For users who can upload but can't connect db, only shows once uploads are enabled on at least one db.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:

After:

TESTING INSTRUCTIONS

Login into the app
Connect a database that is not example and check the logic form above
Remove all connected databases and check the logic from above
Clicking on the connect database menu should open the Connect Database modal
Clicking on the create dataset menu should open the Create Dataset modal

ADDITIONAL INFORMATION

Has associated issue: Unnecessary queries when interacting with the menus #21569
Required feature flags:
Changes UI
Includes DB Migration (follow approval process in SIP-59)
- Migration is atomic, supports rollback & is backwards-compatible
- Confirm DB migration upgrade and downgrade tested
- Runtime estimates and downtime expectations provided
Introduces new feature or API
Removes existing feature or API

codecov · 2022-09-20T14:21:13Z

Codecov Report

Merging #21530 (c3a8c3a) into master (54f6fd6) will increase coverage by 0.01%.
The diff coverage is 62.16%.

❗ Current head c3a8c3a differs from pull request most recent head 78a047d. Consider uploading reports for the commit 78a047d to get more accurate results

@@            Coverage Diff             @@
##           master   #21530      +/-   ##
==========================================
+ Coverage   66.90%   66.92%   +0.01%     
==========================================
  Files        1805     1805              
  Lines       69081    69106      +25     
  Branches     7378     7387       +9     
==========================================
+ Hits        46218    46246      +28     
+ Misses      20953    20952       -1     
+ Partials     1910     1908       -2

Flag	Coverage Δ
javascript	`53.32% <62.16%> (+0.04%)`	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...nd/src/views/CRUD/data/dataset/AddDatasetModal.tsx	`39.13% <0.00%> (-5.06%)`	⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx	`57.73% <ø> (ø)`
...perset-frontend/src/views/components/RightMenu.tsx	`78.47% <74.19%> (+9.61%)`	⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

yousoph · 2022-09-23T00:28:20Z

/testenv up

github-actions · 2022-09-23T00:30:02Z

@yousoph Ephemeral environment spinning up at http://35.86.84.95:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

eschutho · 2022-09-23T18:54:31Z

superset-frontend/src/views/components/RightMenu.test.tsx

@@ -0,0 +1,367 @@
+/**


awesome a new test!!

eschutho

Looks great, and thanks for the speedy improvement on the dropdown menu, too!

yousoph · 2022-09-23T19:18:29Z

/testenv up

github-actions · 2022-09-23T19:23:00Z

@yousoph Ephemeral environment spinning up at http://54.212.237.172:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa · 2022-10-03T16:00:34Z

/testenv up

github-actions · 2022-10-03T16:05:03Z

@jinghua-qa Ephemeral environment spinning up at http://52.12.5.68:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

jinghua-qa · 2022-10-04T07:19:06Z

LGTM!

github-actions · 2022-10-05T19:20:43Z

Ephemeral environment shutdown and build artifacts deleted.

yousoph · 2022-10-13T17:32:06Z

/testenv up

github-actions · 2022-10-13T22:20:02Z

@yousoph Ephemeral environment spinning up at http://35.162.145.27:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

- check whether user has connected to only examples DB , if so, the plus menu will show Connect Database - If user has connected any other DB rather than just examples one, we show Connect dataset - Add tests to right menu

- Change our tests so we can add assertions using the displayed dropdown menus instead of just the setState calls - Putting back our useState hook

- Fix index used to render divider - Force blue and pointer hover for other menus that are not anchors so they all render the same - Stop querying the API to get DB info all the time when opening the menu, instead query the API only when opening Data menu

- Update our test file so we include tests for allow_file_upload

- Considering using the modal on pages with no SPA routes so CI doesn't fail

- Query non examples DB when user canDatabase OR canDataset

jinghua-qa · 2022-10-20T14:57:23Z

/testenv up

jinghua-qa · 2022-10-20T18:59:30Z

Test the alpha and gamma role in local env and verified alpha user can see create dataset in + menu when 1 non-example db is added.

jinghua-qa

LGTM

github-actions · 2022-10-20T19:43:03Z

@jinghua-qa Ephemeral environment spinning up at http://52.38.189.221:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

yousoph · 2022-10-20T23:16:51Z

/testenv up FEATURE_SCHEDULED_QUERIES = TRUE

github-actions · 2022-10-20T23:21:04Z

@yousoph Ephemeral environment spinning up at http://52.40.39.59:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

github-actions · 2022-10-24T20:23:15Z

Ephemeral environment shutdown and build artifacts deleted.

pull-request-size bot added the size/L label Sep 20, 2022

Antonio-RiveroMartnez force-pushed the feature-54861 branch from 1834868 to 35ed446 Compare September 22, 2022 01:34

Antonio-RiveroMartnez closed this Sep 22, 2022

Antonio-RiveroMartnez reopened this Sep 22, 2022

Antonio-RiveroMartnez force-pushed the feature-54861 branch from 35ed446 to 555fabd Compare September 23, 2022 18:40

eschutho reviewed Sep 23, 2022

View reviewed changes

superset-frontend/src/views/components/RightMenu.test.tsx Outdated

@@ -0,0 +1,367 @@

/**

Copy link

Member

eschutho Sep 23, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome a new test!!

eschutho approved these changes Sep 23, 2022

View reviewed changes

Antonio-RiveroMartnez force-pushed the feature-54861 branch from 555fabd to 5086bac Compare September 26, 2022 20:31

pull-request-size bot added size/XL and removed size/L labels Sep 26, 2022

Antonio-RiveroMartnez force-pushed the feature-54861 branch from 5086bac to d78209a Compare October 5, 2022 18:49

Antonio-RiveroMartnez closed this Oct 5, 2022

Antonio-RiveroMartnez reopened this Oct 5, 2022

Antonio-RiveroMartnez closed this Oct 5, 2022

Antonio-RiveroMartnez reopened this Oct 5, 2022

Antonio-RiveroMartnez closed this Oct 5, 2022

Antonio-RiveroMartnez reopened this Oct 5, 2022

Antonio-RiveroMartnez closed this Oct 7, 2022

Antonio-RiveroMartnez reopened this Oct 7, 2022

Antonio-RiveroMartnez closed this Oct 7, 2022

Antonio-RiveroMartnez reopened this Oct 7, 2022

Antonio-RiveroMartnez force-pushed the feature-54861 branch 3 times, most recently from ce7e38f to cc37470 Compare October 12, 2022 20:38

Antonio-RiveroMartnez added 6 commits October 19, 2022 15:41

Right Menu:

54f0d2c

- check whether user has connected to only examples DB , if so, the plus menu will show Connect Database - If user has connected any other DB rather than just examples one, we show Connect dataset - Add tests to right menu

Right Menu:

36e4854

- Change our tests so we can add assertions using the displayed dropdown menus instead of just the setState calls - Putting back our useState hook

Right Menu:

c8941a2

- Fix index used to render divider - Force blue and pointer hover for other menus that are not anchors so they all render the same - Stop querying the API to get DB info all the time when opening the menu, instead query the API only when opening Data menu

Right Menu:

d29a7bb

- Update our test file so we include tests for allow_file_upload

Dataset Modal:

8079cd0

- Considering using the modal on pages with no SPA routes so CI doesn't fail

Right Menu:

78a047d

- Query non examples DB when user canDatabase OR canDataset

Antonio-RiveroMartnez force-pushed the feature-54861 branch from cc37470 to 78a047d Compare October 19, 2022 19:00

jinghua-qa approved these changes Oct 20, 2022

View reviewed changes

hughhhh merged commit c19708b into apache:master Oct 24, 2022

mistercrunch added the 🚢 2.1.3 label Feb 18, 2024

mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected #21530

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected #21530

Antonio-RiveroMartnez commented Sep 20, 2022 •

edited

codecov bot commented Sep 20, 2022 •

edited

yousoph commented Sep 23, 2022

github-actions bot commented Sep 23, 2022

eschutho Sep 23, 2022

eschutho left a comment

yousoph commented Sep 23, 2022

github-actions bot commented Sep 23, 2022

jinghua-qa commented Oct 3, 2022

github-actions bot commented Oct 3, 2022

jinghua-qa commented Oct 4, 2022

github-actions bot commented Oct 5, 2022

yousoph commented Oct 13, 2022

github-actions bot commented Oct 13, 2022

jinghua-qa commented Oct 20, 2022

jinghua-qa commented Oct 20, 2022

jinghua-qa left a comment

github-actions bot commented Oct 20, 2022

yousoph commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

github-actions bot commented Oct 24, 2022

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected #21530

feat(rightmenu): Add Datasets to + Menu and Hide Databases when one has been connected #21530

Conversation

Antonio-RiveroMartnez commented Sep 20, 2022 • edited

SUMMARY

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

codecov bot commented Sep 20, 2022 • edited

Codecov Report

yousoph commented Sep 23, 2022

github-actions bot commented Sep 23, 2022

eschutho Sep 23, 2022

Choose a reason for hiding this comment

eschutho left a comment

Choose a reason for hiding this comment

yousoph commented Sep 23, 2022

github-actions bot commented Sep 23, 2022

jinghua-qa commented Oct 3, 2022

github-actions bot commented Oct 3, 2022

jinghua-qa commented Oct 4, 2022

github-actions bot commented Oct 5, 2022

yousoph commented Oct 13, 2022

github-actions bot commented Oct 13, 2022

jinghua-qa commented Oct 20, 2022

jinghua-qa commented Oct 20, 2022

jinghua-qa left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 20, 2022

yousoph commented Oct 20, 2022

github-actions bot commented Oct 20, 2022

github-actions bot commented Oct 24, 2022

Antonio-RiveroMartnez commented Sep 20, 2022 •

edited

codecov bot commented Sep 20, 2022 •

edited