Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multiple time columns with time grain in Pivot Table v2 #21537

Merged
merged 9 commits into from
Sep 22, 2022

Conversation

zhaoyongjie
Copy link
Member

@zhaoyongjie zhaoyongjie commented Sep 21, 2022

SUMMARY

If the FF Generic Axis is enabled, the Pivot Table v2 will support multiple time columns with time grain. The TIME GRAIN control also moves out from the time section.

There is a limitation in the current design that the Adhoc Column wasn't able to apply the Time Grain, I will open separated PR to support the dynamic detector for the column type.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

After

The time grain is applied on Order Date and Ship Date
image

The time grain is applied on Order Date and Ship Date except Category

image

TESTING INSTRUCTIONS

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #21537 (8f64fe5) into master (4d12e37) will increase coverage by 0.00%.
The diff coverage is 15.00%.

@@           Coverage Diff           @@
##           master   #21537   +/-   ##
=======================================
  Coverage   66.68%   66.68%           
=======================================
  Files        1793     1793           
  Lines       68538    68557   +19     
  Branches     7282     7289    +7     
=======================================
+ Hits        45702    45718   +16     
+ Misses      20974    20966    -8     
- Partials     1862     1873   +11     
Flag Coverage Δ
javascript 52.88% <15.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ugin-chart-pivot-table/src/plugin/controlPanel.tsx 4.16% <0.00%> (-2.98%) ⬇️
...et-ui-chart-controls/src/shared-controls/index.tsx 57.14% <25.00%> (-2.48%) ⬇️
.../plugin-chart-pivot-table/src/plugin/buildQuery.ts 42.85% <33.33%> (-12.70%) ⬇️
...ontend/src/views/CRUD/data/dataset/DatasetList.tsx 57.73% <0.00%> (ø)
...tend/src/views/CRUD/data/database/DatabaseList.tsx 66.00% <0.00%> (ø)
...d/src/SqlLab/components/SaveDatasetModal/index.tsx 52.87% <0.00%> (ø)
...board/components/nativeFilters/FilterBar/index.tsx 66.18% <0.00%> (+5.75%) ⬆️
...rd/components/nativeFilters/FilterBar/keyValue.tsx 40.74% <0.00%> (+22.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@apache apache deleted a comment from github-actions bot Sep 21, 2022
@apache apache deleted a comment from github-actions bot Sep 22, 2022
@zhaoyongjie
Copy link
Member Author

/testenv up FEATURE_GENERIC_CHART_AXES=true

@github-actions
Copy link
Contributor

@zhaoyongjie Ephemeral environment spinning up at http://52.34.7.237:8080. Credentials are admin/admin. Please allow several minutes for bootstrapping and startup.

Copy link
Member

@kgabryje kgabryje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zhaoyongjie zhaoyongjie merged commit e671d80 into apache:master Sep 22, 2022
@github-actions
Copy link
Contributor

Ephemeral environment shutdown and build artifacts deleted.

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/L 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants