Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sqllab): SqlEditorLeftBar listening to database changes #21628

Merged
merged 1 commit into from
Sep 28, 2022

Conversation

Antonio-RiveroMartnez
Copy link
Member

SUMMARY

We stopped listening to database prop changes at some point to only take into account the initial component render. That however, caused the component to always work with the initial database passed as prop and never take into account new user selections. Which you might evidence for example with empty table dropdown after changing DB.

We're bringing that feature back with this fix. Also we're using the right props in our tests and adding a new one to consider the re-renders with new database.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

Before:
error

After:
test

TESTING INSTRUCTIONS

Go to sql lab and do a query on your default data base
In the same query tab, switch databases
Select your table
Try to select a table

ADDITIONAL INFORMATION

  • Has associated issue:
  • Required feature flags:
  • Changes UI
  • Includes DB Migration (follow approval process in SIP-59)
    • Migration is atomic, supports rollback & is backwards-compatible
    • Confirm DB migration upgrade and downgrade tested
    • Runtime estimates and downtime expectations provided
  • Introduces new feature or API
  • Removes existing feature or API

- Listen to database changes again
- Update our tests so now they actually use database info
@hughhhh hughhhh merged commit 71bf267 into apache:master Sep 28, 2022
sadpandajoe pushed a commit to preset-io/superset that referenced this pull request Oct 3, 2022
@sadpandajoe
Copy link
Contributor

🏷️ preset:2022.39

@mistercrunch mistercrunch added 🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels 🚢 2.1.0 and removed 🚢 2.1.3 labels Mar 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏷️ bot A label used by `supersetbot` to keep track of which PR where auto-tagged with release labels size/M 🚢 2.1.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants