fix: time grain can't be removed in explore #21644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zhaoyongjie
changed the title
Codecov Report
@@ Coverage Diff @@
## master #21644 +/- ##
=======================================
Coverage 66.83% 66.83%
=======================================
Files 1798 1798
Lines 68823 68823
Branches 7333 7333
=======================================
Hits 45996 45996
+ Misses 20949 20948 -1
- Partials 1878 1879 +1
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
zhaoyongjie
changed the title
zhaoyongjie
force-pushed
the
fix/fix_time_grain_default_value
branch
from
1b10fc8
to
61eaa87
Compare
zhaoyongjie
force-pushed
the
fix/fix_time_grain_default_value
branch
from
61eaa87
to
d9c2575
Compare
villebro
approved these changes
Sep 30, 2022
Comment on lines
+192
to
+195
| // If a chart is a new one that isn't saved, the 'time_grain_sqla' isn't in the form_data. | ||
| return 'time_grain_sqla' in (state?.form_data ?? {}) | ||
| ? state.form_data?.time_grain_sqla | ||
| : 'P1D'; |
There was a problem hiding this comment.
Is there some reason we're not just doing state.form_data?.time_grain_sqla || 'P1D' here?
There was a problem hiding this comment.
When Time Grain control be set to "Original value" or just removal, the time_grain_sqla in the form_data will be null. If time_grain_sqla get a null value, the 'P1D' will always be set to control, in this case, the chart will never use an empty time grain value.
For instance:
- make a Line Chart and set
Original valuetoTime Grain, and then save it; next, go to chart list; then, reopen the chart. - if use
state.form_data?.time_grain_sqla || 'P1D'the Time Grain will returnP1D
9 tasks
mistercrunch
added
🏷️ bot
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SUMMARY
There is a long-term issue in the
Time Graincontrol that it can't be cleared time grain value even though remove it or selectOriginal value.This PR intends to fix it.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
Before
time.grain.-.before.mov
After
time.grain.after.mov
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION